Migrate fully to pyproject.toml (rebased #1324) #1586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neiljp
force-pushed
the
2025-05-18-pyproject-bump
branch
from
87dfdb7 to
a6b39da
Compare
Previously setup.py specifically excluded tests from being packaged, but recent testing demonstrated this now included other files, including development tools. Moving to use the `include` option for the source is simpler here, combined with the addition of a MANIFEST.in file. The MANIFEST.in file is used by various tools, and appears more reliable than other methods to achieve this, particularly as we move towards using pyproject.toml. For now, this aims to remove all but the absolute minimum files to run. MANIFEST added to .gitlint to allow presence as an area in commit titles.
neiljp
force-pushed
the
2025-05-18-pyproject-bump
branch
4 times, most recently
from
fb29542 to
b85978a
Compare
This transfers details from setup.py to equivalent ones in pyproject.toml, and similarly removes or substitutes references to these files. The previous setup.py file is removed. Note: This introduces 3 other changes from the previous state: * Building packages no longer removes the top title line shown on GitHub * The `zip_safe` property is detected automatically by `setuptools` * The types-setuptools package is included for type-checking This also adds a note to the making-a-new-release doc, since while it was previously out of date, setup.py will now be absent completely.
neiljp
force-pushed
the
2025-05-18-pyproject-bump
branch
3 times, most recently
from
fe6caf8 to
387190a
Compare
neiljp
force-pushed
the
2025-05-18-pyproject-bump
branch
from
387190a to
86a2102
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
Outstanding aspect(s)
External discussion & connections
topicHow did you test this?
Self-review checklist for each commit
Visual changes