Highlight current narrow (rebased/simplified/extended) #1244 #1334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a rebase and minor adjustment to get #1244 working against current
main
.This seems to work well, highlighting the stream in the left panel when in the associated narrow, and with some simple extensions also shows the top-left buttons highlighted when changing to the appropriate narrow.
This still has no tests and may benefit from refactoring - digging into the view to toggle button highlighting is not great.
A final version of something like this would fix #516, like the original.
Tested?
Notes & Questions
I'm particularly interested in the style per theme - this can be changed later, but we can get some reasonable values to begin with.
Visual changes