Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify user if sent/edited message is outside current narrow #781

Closed
kaustubh-nair opened this issue Aug 20, 2020 · 8 comments
Closed

Notify user if sent/edited message is outside current narrow #781

kaustubh-nair opened this issue Aug 20, 2020 · 8 comments
Assignees
@zee-bit
Labels
enhancement New feature or request good first issue Good for newcomers in progress
Milestone
0.7.0

Comments

@kaustubh-nair
Copy link
Member

kaustubh-nair commented Aug 20, 2020 •
edited
Loading

For example, if a user is in topic narrow and edits a message's topic then it would be moved do a different narrow. We should probably display a message in the footer if this happens.
@kaustubh-nair kaustubh-nair added enhancement New feature or request good first issue Good for newcomers labels Aug 20, 2020
@neiljp neiljp mentioned this issue Aug 20, 2020
Closed
@avats-dev
Copy link
Collaborator

@kaustubh-nair Could you explain how I can resolve this?

I'm new to zulip's codebase.

@kaustubh-nair
Copy link
Member Author

@avats-dev You can use model.narrow and other narrow-related methods in the model to detect narrow changes, and use view.set_footer_text() to display the message.

@avats-dev
Copy link
Collaborator

Thanks @kaustubh-nair for the help, I'll try and get back to you if I need some help.

@zee-bit
Copy link
Member

zee-bit commented Nov 12, 2020

Hi @kaustubh-nair, I have a couple of questions:

  1. If a user edits a message topic in a narrow, then he already knows where the message is moved now because he edited it, so why is this needed. Am I missing something?
  2. If we display a message in the footer, what should be the message body?

@kaustubh-nair
Copy link
Member Author

@zee-bit

1, That is correct. Though we want to give the user a pointer as to why the message disappeared from the screen.
2. That's up to you. It's a small enough detail that we can modify during the PR review, if needed. Feel free to take inspiration from the web-app.

@zee-bit
Copy link
Member

zee-bit commented Nov 12, 2020

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @zee-bit! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Nov 13, 2020
@zee-bit
model: Add footer notification for messages.
ee9f358 
This will set a footer text notifying the user everytime
he sends or edits a message that is outside the current
narrow. This will give the user a pointer as to why the
message disappeared from the screen.

Fixes zulip#781.
@zee-bit zee-bit mentioned this issue Nov 13, 2020
Closed
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Nov 14, 2020
@zee-bit
model: Add footer notification for messages.
55f4097 
This will set a footer text notifying the user everytime
he sends or edits a message that is outside the current
narrow. This will give the user a pointer as to why the
message disappeared from the screen.

Fixes zulip#781.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Nov 17, 2020
@zee-bit
model: Add footer notification for messages.
c27cc3b 
This will set a footer text notifying the user everytime
he sends or edits a message that is outside the current
narrow. This will give the user a pointer as to why the
message disappeared from the screen.

Fixes zulip#781.
@zulipbot
Copy link
Member

Hello @zee-bit, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 4 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Dec 19, 2020
@zee-bit
model: Add footer notification for messages.
e0904f0 
This will set a footer text notifying the user everytime
he sends or edits a message that is outside the current
narrow. This will give the user a pointer as to why the
message disappeared from the screen.

Fixes zulip#781.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jan 6, 2021
@zee-bit
model: Add footer notification for messages.
4689b71 
This will set a footer text notifying the user everytime
he sends or edits a message that is outside the current
narrow. This will give the user a pointer as to why the
message disappeared from the screen.

Fixes zulip#781.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jan 8, 2021
@zee-bit
model: Add footer notification for message.
cb2503a 
This commit shows notifications in the footer if a
message sent/edited by user is outside current narrow.
This will give the user a pointer as to why the message
disappeared from the screen. The code is hooked to the
part where message request is sent to the server, hence
preventing check for user_id and message sender_id being
the same.

Tests amended.
Fixes zulip#781.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jan 8, 2021
@zee-bit
model: Add footer notification for message.
2b77369 
This commit shows notifications in the footer if a
message sent/edited by user is outside current narrow.
This will give the user a pointer as to why the message
disappeared from the screen. The code is hooked to the
part where message request is sent to the server, hence
preventing check for user_id and message sender_id being
the same.

Tests amended.
Fixes zulip#781.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jan 8, 2021
@zee-bit
model: Add footer notification for message.
13f3f76 
This commit shows notifications in the footer if a
message sent/edited by user is outside current narrow.
This will give the user a pointer as to why the message
disappeared from the screen. The code is hooked to the
part where message request is sent to the server, hence
preventing check for user_id and message sender_id being
the same.

Fixes zulip#781.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jan 17, 2021
@zee-bit
model: Add footer notification for message.
208a0e0 
This commit shows notifications in the footer if a
message sent/edited by user is outside current narrow.
This will give the user a pointer as to why the message
disappeared from the screen. The code is hooked to the
part where message request is sent to the server, hence
preventing check for user_id and message sender_id being
the same.

Fixes zulip#781.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jan 19, 2021
@zee-bit
model: Add footer notification for message.
ec7e0d6 
This commit shows notifications in the footer if a
message sent/edited by user is outside current narrow.
This will give the user a pointer as to why the message
disappeared from the screen. The code is hooked to the
part where message request is sent to the server, hence
preventing check for user_id and message sender_id being
the same.

Fixes zulip#781.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jan 25, 2021
@zee-bit
model: Add footer notification for message.
e791b4b 
This commit shows notifications in the footer if a
message sent/edited by user is outside current narrow.
This will give the user a pointer as to why the message
disappeared from the screen. The code is hooked to the
part where message request is sent to the server, hence
preventing check for user_id and message sender_id being
the same.

Fixes zulip#781.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jan 28, 2021
@zee-bit
helper/model: Add footer notification for message sent outside narrow.
52ead7c 
This commit generalizes the code for footer notification when a message
is sent/edited outside current narrow. This will give the user a pointer
as to why the message disappeared from the screen. The code is hooked to
the part where message request is sent to the server, hence preventing the
extra check for user_id being same as message_sender_id.

Tests amended.
Fixes zulip#781.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Feb 13, 2021
@zee-bit
helper/model: Add footer notification for message sent outside narrow.
c510ebc 
This commit generalizes the code for footer notification when a message
is sent/edited outside current narrow. This will give the user a pointer
as to why the message disappeared from the screen. The code is hooked to
the part where message request is sent to the server, hence preventing the
extra check for user_id being same as message_sender_id.

Tests amended.
Fixes zulip#781.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Feb 17, 2021
@zee-bit
helper/model: Add footer notification for message sent outside narrow.
1d2152d 
This commit generalizes the code for footer notification when a message
is sent/edited outside current narrow. This will give the user a pointer
as to why the message disappeared from the screen. The code is hooked to
the part where message request is sent to the server, hence preventing the
extra check for user_id being same as message_sender_id.

Tests amended.
Fixes zulip#781.
@neiljp neiljp added this to the Next Release milestone Feb 17, 2021
@neiljp neiljp closed this as completed in 3260e3a Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zee-bit zee-bit

Labels
enhancement New feature or request good first issue Good for newcomers in progress
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

model: Add footer notification for messages. zee-bit/zulip-terminal
5 participants
@neiljp @zulipbot @kaustubh-nair @avats-dev @zee-bit