Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync server-specific unicode emoji with local cache at startup #1250

Open
neiljp opened this issue Aug 24, 2022 · 1 comment
Open

Sync server-specific unicode emoji with local cache at startup #1250

neiljp opened this issue Aug 24, 2022 · 1 comment
Labels
area: emoji enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org FUTURE version parity: 6

Comments

@neiljp
Copy link
Collaborator

neiljp commented Aug 24, 2022

Our current set of supported unicode emoji are irregularly fetched from the current master/main branch using tools/fetch-unicode-emoji-data, translated using another script, and then integrated via a commit with the resulting changes. This uses a file internal to the server source exposed via github.

Zulip 6.0 is expected to support a way to explicitly expose the unicode emoji in use and support providing a url to fetch from and a way to locally cache the url contents via a hash.

The current planned approach is to use cache-control headers, which should be achievable using something like requests-cache. This may also connect with work towards a central configuration location, eg. #678

Unicode emoji are not updated frequently, but as part of this work we likely want to ensure that code that handles emoji and reactions can cope if the emoji are updated, such as if a server is upgraded. We can check with the web app to see how they handle some of these situations, but an error like zulip/zulip-mobile#5430 for mobile motivated this addition to the server.

We'll also want to consider interoperating with older server versions that don't provide this.


@neiljp neiljp added enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org FUTURE labels Aug 24, 2022
@neiljp neiljp changed the title Sync server unicode emoji with local cache at startup Sync server-specific unicode emoji with local cache at startup Apr 22, 2024
@zulipbot
Copy link
Member

Hello @zulip/server-emoji members, this issue was labeled with the "area: emoji" label, so you may want to check it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: emoji enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org FUTURE version parity: 6
Projects
None yet
Development

No branches or pull requests

2 participants