Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'sticky' and 'non-sticky' panel searches #1205

Open
neiljp opened this issue Apr 17, 2022 · 0 comments
Open

Support 'sticky' and 'non-sticky' panel searches #1205

neiljp opened this issue Apr 17, 2022 · 0 comments
Labels
area: UI General user interface update enhancement New feature or request GSoC Possible GSoC project component

Comments

@neiljp
Copy link
Collaborator

neiljp commented Apr 17, 2022

To use a term from #822 and related discussion, 'sticky' refers here to when state is retained, and possibly applied to other actions, and doesn't automatically reset.

Currently the side panel searches (filters) are all 'sticky', in that once one does a search, enters the list and activates on an item (including switching between streams/topics), the search remains.

The existing 'sticky' behavior can be convenient in some situations. For example, one may want to search for some topics in a stream, and retain that filtered list in order to check through other results without needing to re-enter the search/filter text.

On the contrary, there are a number of situations where searches may be preferably non-sticky:

  • one can search and use enter/t, and the search/filter will revert upon showing the stream list
    • in particular, rather than scrolling down a long list to use enter/t, one can search and do so
    • this avoids needing to navigate to the stream list and use esc to clear the list
  • one may wish to find one particular user via w, but after leaving the view simply want the list to revert automatically
    • again, this avoids the need to navigate back to the user list and hit esc

As discussed in #zulip-terminal > UX for stream search #T1205 we can consider the non-sticky case to be the more common case, but as above and in the discussion there, we wish to maintain the sticky case.

The current proposed solution is therefore:

  • adjust current search filter keys to be upper-case (W/K), so requiring an extra modifier, but very close and simple to remember
  • lower-case keys should be adjusted to clear search/filter state after activation/use/leaving-view
  • search boxes should show both keys

Stream/topic list and user list may require different approaches.

@neiljp neiljp added enhancement New feature or request area: UI General user interface update GSoC Possible GSoC project component labels Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI General user interface update enhancement New feature or request GSoC Possible GSoC project component
Projects
None yet
Development

No branches or pull requests

1 participant