Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display associated topics when a stream is selected (panel-follows-narrow) #1190

Open
plugyawn opened this issue Apr 7, 2022 · 5 comments
Open
Labels
area: UI General user interface update enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org

Comments

@plugyawn
Copy link
Collaborator

plugyawn commented Apr 7, 2022

The web-app displays sub-streams when the stream is selected, which is a convenient way to narrow to them when needed.

For reference, the implementation should look something like this, from https://github.com/Bios-Marcel/cordless, an open-source Discord terminal client.
Screenshot 2022-04-08 at 1 35 24 AM

@neiljp
Copy link
Collaborator

neiljp commented Apr 7, 2022

@plugyawn Are you aware of using the t key on a stream to show a list of topics? If not, I'd recommend reviewing the (user) tutorial.

In terms of other directions I agree we could show a nested view a little like the web app, though even there it can be toggled into an all-topics view, like we achieve with t straight away.

There was talk of using modifier keys to auto-reset views, eg. after selecting something to narrow to, but I don't remember if it applied to t.

We could also improve UI hints on the screen that t exists, other than in the help menu, which we've improved over time for other areas. We perhaps considered having this at the base of the stream/topic list in a topic, you may be able to find it through searching.

@plugyawn
Copy link
Collaborator Author

plugyawn commented Apr 7, 2022

@neiljp Sorry, yeah, I forgot that it existed; I've read the user tutorial, must've slipped my mind.

But I think the issue still stands -- once you press enter to narrow to a stream, the indication that you've narrowed to a particular stream needs to be more explicit.

So when you're in the all-messages view, the streams are not unravelled, but when you narrow to, say, zulip-terminal, the last 4 or 5 topics are listed as a tree, which does two things -

  • Shows the stream you've narrowed to (since the header is not a great way to show the stream that's open -- you're looking at the left column when selecting the stream and then looking at the header to confirm if it's the right stream that opened).
    That provides a feedback for the stream selection.
  • Gives users an easy way to jump between topics, without having to go through the hassle of knowing the t command and actually using it to navigate. Also, both t and esc should allow users to get back to the streams page, right now it's just t.

Also, totally think we should hint towards the t functionality more.

@neiljp
Copy link
Collaborator

neiljp commented Apr 8, 2022

@plugyawn Since this is generating more discussion than focus on a single point, and to generate wider thoughts, I've put some of my responses into a topic in the stream provisionally titled Panel-follows-narrow.

I'd suggest we raise the other points separately, since they're items to improve without such a feature enabled, or at least which can be discussed/developed in parallel. Note though that esc historically (and currently) is equivalent to a (at least on a message), so that could also be confusing, though we do use other keys differently in different contexts.

@neiljp neiljp added enhancement New feature or request area: UI General user interface update further discussion required Discuss this on #zulip-terminal on chat.zulip.org labels Apr 8, 2022
@plugyawn
Copy link
Collaborator Author

plugyawn commented Apr 8, 2022

Yep! Sounds like the best way to do this. Should I close this issue and raise individual issues for the discussed points?

Also -- about the esc thing, thanks for the context! Makes more sense now.

@neiljp
Copy link
Collaborator

neiljp commented Apr 8, 2022

Let's leave this issue open. I'm going to rename the issue slightly to represent what seems to be the main point in the context of ZT.

@neiljp neiljp changed the title Display associated sub-streams when a stream is selected. Display associated topics when a stream is selected (panel-follows-narrow) Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI General user interface update enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org
Projects
None yet
Development

No branches or pull requests

2 participants