views: Migrate mouse_event to use keys_for_command.

The migration helps in using keys_for_command in the test as well.

Tests amended for Streams/UsersView and added for TopicsView.

Author: preetmishra

tests/ui/test_ui_tools.py

@@ -477,14 +477,10 @@ def test_keypress_navigation(self, mocker, stream_view,
         stream_view.keypress(size, key)
         super_view.assert_called_once_with(size, expected_key)
 
-    @pytest.mark.parametrize('button, key', [
-            (4, 'up'),
-            (5, 'down'),
-        ],
-        ids=['scroll_wheel_up', 'scroll_wheel_down']
-    )
-    def test_mouse_event(self, mocker, stream_view, button, key,
-                         size=(200, 20)):
+    def test_mouse_event(self, mocker, stream_view,
+                         mouse_press_key_button_pair, size=(200, 20)):
+        key, button = mouse_press_key_button_pair
+        mocker.patch(VIEWS + '.keys_for_command', return_value=[key])
         mocker.patch.object(stream_view, 'keypress')
         stream_view.mouse_event(size, 'mouse press', button, 1, 1, 'WIDGET')
         stream_view.keypress.assert_called_once_with(size, key)
@@ -671,6 +667,14 @@ def test_keypress_navigation(self, mocker, topic_view,
         topic_view.keypress(size, key)
         super_view.assert_called_once_with(size, expected_key)
 
+    def test_mouse_event(self, mocker, topic_view, mouse_press_key_button_pair,
+                         size=(200, 20)):
+        key, button = mouse_press_key_button_pair
+        mocker.patch(VIEWS + '.keys_for_command', return_value=[key])
+        mocker.patch.object(topic_view, 'keypress')
+        topic_view.mouse_event(size, 'mouse press', button, 1, 1, 'WIDGET')
+        topic_view.keypress.assert_called_with(size, key)
+
 
 class TestUsersView:
 
@@ -687,14 +691,10 @@ def test_keypress_navigation(self, mocker, user_view,
         user_view.keypress(size, key)
         super_view.assert_called_once_with(size, expected_key)
 
-    @pytest.mark.parametrize('button, key', [
-            (4, 'up'),
-            (5, 'down'),
-        ],
-        ids=['scroll_wheel_up', 'scroll_wheel_down']
-    )
-    def test_mouse_event(self, mocker, user_view, button, key,
+    def test_mouse_event(self, mocker, user_view, mouse_press_key_button_pair,
                          size=(200, 20)):
+        key, button = mouse_press_key_button_pair
+        mocker.patch(VIEWS + '.keys_for_command', return_value=[key] * 5)
         mocker.patch.object(user_view, 'keypress')
         user_view.mouse_event(size, 'mouse press', button, 1, 1, 'WIDGET')
         user_view.keypress.assert_called_with(size, key)

zulipterminal/ui_tools/views.py

@@ -284,10 +284,10 @@ def mouse_event(self, size: urwid_Size, event: str, button: int, col: int,
                     row: int, focus: bool) -> bool:
         if event == 'mouse press':
             if button == 4:
-                self.keypress(size, 'up')
+                self.keypress(size, keys_for_command('GO_UP').pop())
                 return True
             elif button == 5:
-                self.keypress(size, 'down')
+                self.keypress(size, keys_for_command('GO_DOWN').pop())
                 return True
         return super().mouse_event(size, event, button, col, row, focus)
 
@@ -377,10 +377,10 @@ def mouse_event(self, size: urwid_Size, event: str, button: int, col: int,
                     row: int, focus: bool) -> bool:
         if event == 'mouse press':
             if button == 4:
-                self.keypress(size, 'up')
+                self.keypress(size, keys_for_command('GO_UP').pop())
                 return True
             elif button == 5:
-                self.keypress(size, 'down')
+                self.keypress(size, keys_for_command('GO_DOWN').pop())
                 return True
         return super().mouse_event(size, event, button, col, row, focus)
 
@@ -422,11 +422,11 @@ def mouse_event(self, size: urwid_Size, event: str, button: int, col: int,
         if event == 'mouse press':
             if button == 4:
                 for _ in range(5):
-                    self.keypress(size, 'up')
+                    self.keypress(size, keys_for_command('GO_UP').pop())
                 return True
             elif button == 5:
                 for _ in range(5):
-                    self.keypress(size, 'down')
+                    self.keypress(size, keys_for_command('GO_DOWN').pop())
         return super().mouse_event(size, event, button, col, row, focus)
 
     def keypress(self, size: urwid_Size, key: str) -> Optional[str]: