Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Upgrade RN to v0.64.3, from v0.64.2 #5167

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

chrisbobbe
Copy link
Contributor

This is just a minor version that came out a month ago, which was
after our big v0.64 upgrade, #4991.

The changelog entry [1] has just one item:

Fixed

  • For Android, general fixes to Appearance API and also fixes
    AppCompatDelegate.setDefaultNightMode(). For iOS, now works
    correctly when setting window.overrideUserInterfaceStyle
    (25a2c608f7
    by @mrbrentkelly)

We don't use those mentioned APIs, so this should be fine and not
disruptive.

There are no changes to the template app.

Tested on my iPhone 13 Pro running iOS 15, and on the office Android
device (Samsung Galaxy S9 running Android 9), and I didn't encounter
any building or running failures, and nothing was obviously wrong in
the app.

[1] https://github.com/facebook/react-native/blob/main/CHANGELOG.md#v0643

@chrisbobbe chrisbobbe added the dependencies Pull requests that update a dependency file label Dec 13, 2021
This is just a minor version that came out a month ago, which was
after our big v0.64 upgrade, zulip#4991.

The changelog entry [1] has just one item:

  ### Fixed

  - For Android, general fixes to Appearance API and also fixes
    AppCompatDelegate.setDefaultNightMode(). For iOS, now works
    correctly when setting window.overrideUserInterfaceStyle
    ([25a2c608f7](facebook/react-native@25a2c60)
    by [@mrbrentkelly](https://github.com/mrbrentkelly))

We don't use those mentioned APIs, so this should be fine and not
disruptive.

There are no changes to the template app.

Tested on my iPhone 13 Pro running iOS 15, and on the office Android
device (Samsung Galaxy S9 running Android 9), and I didn't encounter
any building or running failures, and nothing was obviously wrong in
the app.

[1] https://github.com/facebook/react-native/blob/main/CHANGELOG.md#v0643
@gnprice
Copy link
Member

gnprice commented Dec 16, 2021

Thanks! Merging.

@gnprice gnprice merged commit bfdf99b into zulip:main Dec 16, 2021
@chrisbobbe chrisbobbe deleted the pr-rn-0-64-3 branch January 5, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants