deps: Remove two peer-deps we don't need anymore (helpful for RN v0.64 upgrade). #4989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
P1 high-priority
dependencies
We added these in 62621ef, so we could add `jest-expo`. Empirically, it's fine to remove these and keep `jest-expo`; we don't get any peer-dep warnings after doing so.
gnprice
force-pushed
the
pr-remove-two-peer-deps
branch
from
04beb81
to
f98ff1c
Compare
|
Thanks! Looks good, merging. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added these in 62621ef, so we could add
jest-expo.Empirically, it's fine to remove these and keep
jest-expo; wedon't get any peer-dep warnings after doing so.
(Inheriting priority from #4426, the issue for the RN v0.64 upgrade.)