Switch to @react-native-async-storage/async-storage. #4894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All looks good! Two comments, both just in commit messages: I think you intended this to be a link to this PR 😄 I think you mean add caret, right? (Or "remove pinning", except there isn't a great concise jargon term in that direction because "pinning" is often used to mean the function Please merge as will after fixing those. |
… move.
This seems to be a move / rename, not something more disruptive like
a rewrite. In fact, I don't expect this to be any more disruptive
than taking the next patch version in the library's natural
progression. If I add the new-location package at its first
available version, 1.13.0, and I keep the old one at its latest
available (and the one we've been on), 1.12.1, I see very few
differences between them [1]:
git diff --no-index \
node_modules/@react-native-{community,async-storage}/async-storage
The package in its new location keeps the changelog entries from
when it was maintained at the old location. That changelog confirms
that 1.13.0 comes right after 1.12.1, and the 1.13.0 entry looks
like a match for what we saw in the `git diff --no-index` output.
So this shouldn't be disruptive at all, unless 1.13.0 has
unannounced breaking changes.
[1] For the output, see the PR description at
zulip#4894 (comment).
This takes us to v1.15.5, the current latest. No breaking changes are announced in the changelog [1], but 1.13.3 does announce this: > After upgrading to v1.13.3+, remember to: > > - remove Pods directory (ios/Pods) > - clean build directory through Xcode (in menu: Product -> Clean > Build Folder) > - install dependencies again (`pod install`) All this didn't seem obviously necessary (except `pod install`, which we always do), but I did it anyway. v1.13.4 gets us @react-native-async-storage/async-storagefb0ce97e3, which we'll need for the RN v0.64 upgrade, zulip#4426. [1] https://github.com/react-native-async-storage/async-storage/releases Fixes: zulip#4890
chrisbobbe
force-pushed
the
pr-async-storage-move
branch
from
00fe105 to
2c559b1
Compare
Done, thanks for the review! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be a move / rename, not something more disruptive like
a rewrite. In fact, I don't expect this to be any more disruptive
than taking the next patch version in the library's natural
progression. If I add the new-location package at its first
available version, 1.13.0, and I keep the old one at its latest
available (and the one we're on currently), 1.12.1, I see very few
differences between them:
And those differences seem like a good match for the changelog entry for 1.13.0: https://github.com/react-native-async-storage/async-storage/releases/tag/v1.13.0
Fixes: #4890