Poll messages should show reactions, tags, and outbox spinner

[gnprice]

Expected behavior:

1. Someone sends a poll message.
2. The message gets some reactions; it gets edited or moved; and you star it.
3. In mobile, you view it in the message list.
4. The message shows up including its reactions, the "edited" marker, and the "starred" marker.

Actual behavior:
4. The message shows up without those things.

The cause of this is that in src/webview/html/message.js we render the reactions as part of the messageBody function:

  return template`\
$!${processAlertWords(content, id, alertWords, flags)}
$!${isOutbox ? '<div class="loading-spinner outbox-spinner"></div>' : ''}
$!${messageTagsAsHtml(!!flags.starred[id], last_edit_timestamp)}
$!${messageReactionListAsHtml(reactions, ownUser.user_id, allImageEmojiById)}`;

but for a widget message (including a poll message) we call widgetBody instead of messageBody:

  const bodyHtml =
    message.submessages && message.submessages.length > 0
      ? widgetBody(message, backgroundData.ownUser.user_id)
      : messageBody(backgroundData, message);

Instead, those last three lines of messageBody should move up the call stack, and get applied after we've called either widgetBody or processAlertWords.

(I'm not sure how things behave in local echo when you send a poll message, which is why the behavior description above doesn't include the outbox spinner. But clearly we should be showing the spinner when it's an outbox message.)

[priyanshu-kun]

Hey, will you guide me how can I start working on thing that you mention above if that thing is still relevant, I'm somewhat understand your issue and I believe I can work upon that but I don't have clear understanding where should I start working on that.

[alya]

@priyanshu-kun please refer to our guide to asking great questions for some tips on how to get help figuring out how to approach an issue. It's very difficult to answer general questions along the lines of, "how do I get started?" Thanks!

[mschuler10]

@zulipbot claim

[chrisbobbe]

Hi @mschuler10, unfortunately the core team won't be able to review pull requests for this feature, as our efforts are concentrated on building a new Zulip mobile client in Flutter.

[mschuler10]

OK @chrisbobbe, thank you for your reply!