Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab navigation isn't animated #3566

Open
gnprice opened this issue Jul 24, 2019 · 0 comments
Open

Tab navigation isn't animated #3566

gnprice opened this issue Jul 24, 2019 · 0 comments
Labels
a-navigation blocked on other work To come back to after another related PR, or some other task.

Comments

@gnprice
Copy link
Member

gnprice commented Jul 24, 2019 •
edited
Loading

I introduced this in baafbc2, as a workaround for react-navigation/react-navigation#5713 which we were about to hit with the upcoming upgrade #3399 of RN from v0.57 to v0.59. (The workaround was suggested in a helpful comment there.)

The issue thread sounds like the issue is fixed in a later release of react-navigation. We're on a quite old release, 1.6.1. Before fixing this, we likely need to upgrade to react-navigation v3: #3573 . There's some partial work toward an upgrade in #2702 and #3502 .
@gnprice gnprice added the blocked on other work To come back to after another related PR, or some other task. label Jul 24, 2019
This was referenced Jul 24, 2019
Merged
Closed
@gnprice gnprice mentioned this issue Oct 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-navigation blocked on other work To come back to after another related PR, or some other task.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gnprice @chrisbobbe