Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message view often blanks after sending a message #1549

Closed
gnprice opened this issue Dec 15, 2017 · 5 comments
Closed

Message view often blanks after sending a message #1549

gnprice opened this issue Dec 15, 2017 · 5 comments
Labels
bug upstream: RN Issues related to an issue in React Native

Comments

@gnprice
Copy link
Member

gnprice commented Dec 15, 2017

On 5.0.46 on iOS, when I send a message, often the message view goes blank. It looks like this:

When I touch and scroll slightly, the messages reappear.

@gnprice gnprice added the bug label Dec 15, 2017
@borisyankov
Copy link
Contributor

@jainkuniya this might be related to the keyboard + scroll code you wrote. Could you have a look?

@jainkuniya
Copy link
Member

Main issue is, scrolling a list from JS. May be bug in react-native scrollToEnd/scrollTo methods (not completely sure, but yea) (or might be due to our custom scrollView native code is not updated).

The issue is, scrollView is scrolled but its views are not updated. Resulted in white screen (no child views are displayed). Then when little scroll is performed, re-calcuation takes place and child views are updated.
Somewhat similar to facebook/react-native#13202

On 5.0.46 on iOS, when I send a message, often the message view goes blank.

Solution: remove scrolling related stuff (scroll to first unread message, scroll after sending message, and when keyboards pops) from JS part and implement them natively with proper checks.
For Android issue of blank screen was fixed by 1e51768.

@jainkuniya
Copy link
Member

This will be automatically solved once we are done with WebView

@jainkuniya
Copy link
Member

@zulipbot claim

@jainkuniya
Copy link
Member

Now with the newer MessageList, it is no longer relevant, can be closed now.

@gnprice gnprice added the upstream: RN Issues related to an issue in React Native label Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug upstream: RN Issues related to an issue in React Native
Projects
None yet
Development

No branches or pull requests

4 participants