Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: zulip/zulip-mobile
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: zulip/zulip-mobile
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: stable-17
Choose a head ref
  • 4 commits
  • 4 files changed
  • 2 contributors

Commits on Sep 22, 2018

  1. lightbox: Update dependency to fix breakage on iOS (#2654). 

    Fixes #2654.  The cause of that issue was that the PhotoView
component, from the library `react-native-photo-view`, was ignoring
headers passed in the `source` prop; without the `Authorization`
header, the Zulip server refuses access.

This was reported upstream:
  alwx/react-native-photo-view#101
and was fixed in master with commit c58fd6b30:
  alwx/react-native-photo-view#127
but the fix has yet to be published on NPM.

So, refer in our package.json directly to that commit, using the
special abbreviated syntax for a GitHub URL.  For reference, see:
  https://docs.npmjs.com/files/package.json#github-urls
    @jackrzhang @gnprice
    jackrzhang authored and gnprice committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    753dede View commit details
    Browse the repository at this point in the history

  2. autocomplete: Avoid rendering a huge list of emoji choices. 

    Fixes #2987.  When you type a message with a colon in it, like
"Here you go:", and try to send it... the app effectively freezes.

On closer study, everything gets unstuck if you wait a minute or two.
And one thing that's certainly happening in this case is that our
`AutocompleteView` is making an `EmojiAutocomplete` with a filter of
just ''; the resulting list of emoji will be all ~1500 or so of them.
The `AutocompleteView` ensures the `EmojiAutocomplete` isn't *visible*
when the filter is empty... but it is *there*.

We could kludge this by short-circuiting things when the filter is
empty, but we'd still have a lot of emoji after typing something
that's a popular prefix for emoji names... like `:s`, which matches a
total of 222 emoji in our standard set.  And, in fact, trying the
repro with a message like ":s" produces the same symptoms -- just for
not for quite as long.

On the other hand, trying this with `@` or `#`, even on a busy org
with tons of users and streams like chat.zulip.org, causes no problem;
so the issue doesn't seem to affect PeopleAutocomplete or
StreamAutocomplete.

Seems like we must have had some pretty severe performance regression
in the emoji autocomplete list.  We should fix that, but first let's
stop the bleeding.  It's currently impossible to scroll around the
list due to another issue (#2917), so we can set the limit tightly
because more emoji than fit on the screen won't do any good anyway.
    @gnprice
    gnprice committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    6ed18b9 View commit details
    Browse the repository at this point in the history

  3. tools: Add quick bump-version script to streamline releases. 

    This is a mechanical task I do for each release, where I go glance
at an example previous such change; go open a couple of files in an
editor; find the right lines, edit them; and double-check I didn't
typo something.  A computer can do it faster!
    @gnprice
    gnprice committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    82c8d3c View commit details
    Browse the repository at this point in the history

  4. tools/bump-version: Add auto-commit. 

    The slick Bash feature with `${...@q}` that I use here for nicely
shell-quoting a value is one I just now learned when looking for
alternatives in the Bash manual.  I'd never seen it before; which
turns out to be because it's "only" two years old!
    @gnprice
    gnprice committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    57a130a View commit details
    Browse the repository at this point in the history
Loading