flow [nfc]: Better indicate flow bugs in a few suppressions.

See https://flow.org/en/docs/errors/.
zulip · Jan 27, 2021 · d2d8630 · d2d8630
1 parent 26f66f7
commit d2d8630
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/src/boot/replaceRevive.js b/src/boot/replaceRevive.js
@@ -57,25 +57,25 @@ function replacer(key, value) {
 
   switch (Object.getPrototypeOf(origValue)) {
     // Flow bug: https://github.com/facebook/flow/issues/6110
-    case (ZulipVersion.prototype: $FlowFixMe):
+    case (ZulipVersion.prototype: $FlowIssue):
       return { data: value.raw(), [SERIALIZED_TYPE_FIELD_NAME]: 'ZulipVersion' };
-    case (URL.prototype: $FlowFixMe):
+    case (URL.prototype: $FlowIssue):
       return { data: origValue.toString(), [SERIALIZED_TYPE_FIELD_NAME]: 'URL' };
-    case (GravatarURL.prototype: $FlowFixMe):
+    case (GravatarURL.prototype: $FlowIssue):
       return { data: GravatarURL.serialize(value), [SERIALIZED_TYPE_FIELD_NAME]: 'GravatarURL' };
-    case (UploadedAvatarURL.prototype: $FlowFixMe):
+    case (UploadedAvatarURL.prototype: $FlowIssue):
       return {
         data: UploadedAvatarURL.serialize(value),
         [SERIALIZED_TYPE_FIELD_NAME]: 'UploadedAvatarURL',
       };
-    case (FallbackAvatarURL.prototype: $FlowFixMe):
+    case (FallbackAvatarURL.prototype: $FlowIssue):
       return {
         data: FallbackAvatarURL.serialize(value),
         [SERIALIZED_TYPE_FIELD_NAME]: 'FallbackAvatarURL',
       };
-    case (Immutable.List.prototype: $FlowFixMe):
+    case (Immutable.List.prototype: $FlowIssue):
       return { data: value, [SERIALIZED_TYPE_FIELD_NAME]: 'ImmutableList' };
-    case (Immutable.Map.prototype: $FlowFixMe): {
+    case (Immutable.Map.prototype: $FlowIssue): {
       const firstKey = origValue.keySeq().first();
       return {
         data: value,
@@ -109,8 +109,8 @@ function replacer(key, value) {
   const origValuePrototype = Object.getPrototypeOf(origValue);
   invariant(
     // Flow bug: https://github.com/facebook/flow/issues/6110
-    origValuePrototype === (Object.prototype: $FlowFixMe)
-      || origValuePrototype === (Array.prototype: $FlowFixMe),
+    origValuePrototype === (Object.prototype: $FlowIssue)
+      || origValuePrototype === (Array.prototype: $FlowIssue),
     'unexpected class',
   );
 

diff --git a/src/presence/presenceReducer.js b/src/presence/presenceReducer.js
@@ -45,13 +45,13 @@ export default (state: PresenceState = initialState, action: Action): PresenceSt
           ...state[action.email],
           // Flow bug (unresolved):
           // https://github.com/facebook/flow/issues/8276
-          // $FlowFixMe
+          // $FlowIssue #8276
           ...action.presence,
           aggregated: getAggregatedPresence({
             ...state[action.email],
             // Flow bug (unresolved):
             // https://github.com/facebook/flow/issues/8276
-            // $FlowFixMe
+            // $FlowIssue #8276
             ...action.presence,
           }),
         },

diff --git a/src/webview/html/template.js b/src/webview/html/template.js
@@ -14,7 +14,7 @@ import escape from 'lodash.escape';
  *   template`Hello $\!${&<world}` -> 'Hello $!&amp;&lt;world'
  */
 export default (strings: string[], ...values: Array<string | number>) => {
-  // $FlowFixMe[prop-missing] github.com/facebook/flow/issues/2616
+  // $FlowIssue #2616 github.com/facebook/flow/issues/2616
   const raw: string[] = strings.raw; // eslint-disable-line prefer-destructuring
   const result = [];
   values.forEach((value, i) => {