Skip to content

Commit c4d2a37

Browse files
chrisbobbegnprice
authored andcommitted
flow: Upgrade to v0.126.
As noted in a recent commit where we upgraded to Flow v0.125, we don't usually bump the Flow version outside of a React Native upgrade commit. But I found that we could get v0.126 without any added Flow errors in React Native code -- which is even better than the situation with Flow v0.125, where we saw one Flow error in one file. Being on v0.126 is nice because we'll finally be able to drop our comments like "this should really be exact -- see note in jsonable.js" on many objects with indexer properties, and make those object types exact. - That, in turn, will help us address #3452 more productively ("Convert all object types to exact, or explicitly-inexact"). - Fixing #3452 is really a prerequisite for taking facebook/react-native@050a7dd01 (switching on `exact_by_default`), which is on the path to the RN v0.64 upgrade. [1] https://flow.org/en/docs/config/options/#toc-exact-by-default-boolean
1 parent c666daf commit c4d2a37

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.flowconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,4 +123,4 @@ module.file_ext=.json
123123
module.file_ext=.ios.js
124124

125125
[version]
126-
^0.125.0
126+
^0.126.0

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@
116116
"eslint-plugin-prettier": "^3.2.0",
117117
"eslint-plugin-react": "^7.21.5",
118118
"eslint-plugin-react-hooks": "^4.2.0",
119-
"flow-bin": "^0.125.0",
119+
"flow-bin": "^0.126.0",
120120
"flow-coverage-report": "^0.6.0",
121121
"flow-typed": "^2.4.0",
122122
"immutable-devtools": "^0.1.5",

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5621,10 +5621,10 @@ flow-annotation-check@1.8.1:
56215621
glob "7.1.1"
56225622
load-pkg "^3.0.1"
56235623

5624-
flow-bin@^0.125.0:
5625-
version "0.125.1"
5626-
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.125.1.tgz#7edbc71e7dc39ddef18086ef75c714bbf1c5917f"
5627-
integrity sha512-jEury9NTXylxQEOAXLWEE945BjBwYcMwwKVnb+5XORNwMQE7i5hQYF0ysYfsaaYOa7rW/U16rHBfwLuaZfWV7A==
5624+
flow-bin@^0.126.0:
5625+
version "0.126.1"
5626+
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.126.1.tgz#2726595e1891dc35b379b5994627432df4ead52c"
5627+
integrity sha512-RI05x7rVzruRVJQN3M4vLEjZMwUHJKhGz9FmL8HN7WiSo66/131EyJS6Vo8PkKyM2pgT9GRWfGP/tXlqS54XUg==
56285628

56295629
flow-coverage-report@^0.6.0:
56305630
version "0.6.2"

0 commit comments

Comments
 (0)