ActionSheets: Remove message arg from showHeaderActionSheet

showHeaderActionSheet now takes a stream and topic, rather than a
message, since we only used the stream and topic anyways.

Author: WesleyAC

src/message/messageActionSheet.js

@@ -1,5 +1,4 @@
 /* @flow strict-local */
-import invariant from 'invariant';
 import { Clipboard, Share, Alert } from 'react-native';
 
 import * as NavigationService from '../nav/NavigationService';
@@ -27,7 +26,6 @@ import * as api from '../api';
 import { showToast } from '../utils/info';
 import { doNarrow, deleteOutboxMessage, navigateToEmojiPicker } from '../actions';
 import { navigateToMessageReactionScreen } from '../nav/navActions';
-import { streamNameOfStreamMessage } from '../utils/recipient';
 import { deleteMessagesForTopic } from '../topics/topicActions';
 import * as logging from '../utils/logging';
 
@@ -373,7 +371,8 @@ export const showHeaderActionSheet = ({
   showActionSheetWithOptions,
   callbacks,
   backgroundData,
-  message,
+  topic,
+  stream,
 }: {|
   showActionSheetWithOptions: ShowActionSheetWithOptions,
   callbacks: {|
@@ -388,13 +387,13 @@ export const showHeaderActionSheet = ({
     ownUser: User,
     flags: FlagsState,
   }>,
-  message: Message | Outbox,
+  stream: string,
+  topic: string,
 |}): void => {
-  invariant(message.type === 'stream', 'showHeaderActionSheet: got PM');
   const buttonList = constructHeaderActionButtons({
     backgroundData,
-    stream: streamNameOfStreamMessage(message),
-    topic: message.subject,
+    stream,
+    topic,
   });
   const callback = buttonIndex => {
     (async () => {
@@ -403,8 +402,8 @@ export const showHeaderActionSheet = ({
         await pressedButton({
           ...backgroundData,
           ...callbacks,
-          stream: streamNameOfStreamMessage(message),
-          topic: message.subject,
+          stream,
+          topic,
         });
       } catch (err) {
         Alert.alert(callbacks._(pressedButton.errorMessage), err.message);
@@ -413,7 +412,7 @@ export const showHeaderActionSheet = ({
   };
   showActionSheetWithOptions(
     {
-      title: `#${streamNameOfStreamMessage(message)} > ${message.subject}`,
+      title: `#${stream} > ${topic}`,
       options: buttonList.map(button => callbacks._(button.title)),
       cancelButtonIndex: buttonList.length - 1,
     },

src/webview/handleOutboundEvents.js

@@ -9,7 +9,7 @@ import type { BackgroundData } from './MessageList';
 import type { ShowActionSheetWithOptions } from '../message/messageActionSheet';
 import type { JSONableDict } from '../utils/jsonable';
 import { showToast } from '../utils/info';
-import { pmUiRecipientsFromMessage } from '../utils/recipient';
+import { streamNameOfStreamMessage, pmUiRecipientsFromMessage } from '../utils/recipient';
 import { isUrlAnImage } from '../utils/url';
 import * as logging from '../utils/logging';
 import { filterUnreadMessagesInRange } from '../utils/unread';
@@ -218,7 +218,8 @@ const handleLongPress = (
         showActionSheetWithOptions,
         callbacks: { dispatch, startEditMessage, _ },
         backgroundData,
-        message,
+        stream: streamNameOfStreamMessage(message),
+        topic: message.subject,
       });
     } else if (message.type === 'private') {
       const label = pmUiRecipientsFromMessage(message, backgroundData.ownUser.user_id)