Skip to content

msglist: Fix mark-as-read button icon color in dark mode #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2024
Merged

msglist: Fix mark-as-read button icon color in dark mode #927

merged 3 commits into from
Sep 9, 2024

Conversation

chrisbobbe
Copy link
Collaborator

@chrisbobbe chrisbobbe commented Sep 4, 2024 •
edited
Loading 

msglist: Fix mark-as-read button icon color in dark mode

After sweeping through the message-list screen to implement dark
theme (#843), in late July, the Flutter framework merged
flutter/flutter#143501, in early August. This made it so our
`foregroundColor` no longer controlled the icon color, as promised
in the dartdocs of `foregroundColor` and `iconColor`.

I opened an issue for Flutter about the inconsistency with the doc:
  https://github.com/flutter/flutter/issues/154644
and sent a PR to resolve it, by updating the doc (which the author
of 143501 had said was the right fix):
  https://github.com/flutter/flutter/pull/154646

Fixes: #926

@chrisbobbe chrisbobbe added the a-msglist The message-list screen, except what's label:a-content label Sep 4, 2024
@chrisbobbe chrisbobbe force-pushed the pr-mark-as-read-button-icon branch 2 times, most recently from 6428e01 to de3f8d0 Compare September 4, 2024 22:23
@chrisbobbe
Copy link
Collaborator Author

Before After
image image

@chrisbobbe @gnprice
msglist [nfc]: Fix an indentation nit
ba82907
@chrisbobbe @gnprice
msglist [nfc]: Use more concise WidgetStatePropertyAll
2dda626
@chrisbobbe @gnprice
msglist: Fix mark-as-read button icon color in dark mode
5dab0a6 
After sweeping through the message-list screen to implement dark
theme (zulip#843), in late July, the Flutter framework merged
flutter/flutter#143501, in early August. This made it so our
`foregroundColor` no longer controlled the icon color, as promised
in the dartdocs of `foregroundColor` and `iconColor`.

I opened an issue for Flutter about the inconsistency with the doc:
  flutter/flutter#154644
and sent a PR to resolve it, by updating the doc (which the author
of 143501 had said was the right fix):
  flutter/flutter#154646

Fixes: zulip#926
@gnprice gnprice force-pushed the pr-mark-as-read-button-icon branch from de3f8d0 to 5dab0a6 Compare September 9, 2024 20:18
@gnprice gnprice added the integration review Added by maintainers when PR may be ready for integration label Sep 9, 2024
@gnprice gnprice merged commit 5dab0a6 into zulip:main Sep 9, 2024
@gnprice
Copy link
Member

gnprice commented Sep 9, 2024

Thanks! Looks good ­— merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
a-msglist The message-list screen, except what's label:a-content integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

msglist: Mark-as-read button icon color is wrong in dark mode
2 participants
@chrisbobbe @gnprice