Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak dark theme for slightly higher contrast #973

Open
gnprice opened this issue Sep 30, 2024 · 4 comments · May be fixed by #991
Open

Tweak dark theme for slightly higher contrast #973

gnprice opened this issue Sep 30, 2024 · 4 comments · May be fixed by #991
Assignees
Labels
a-design Visual and UX design

Comments

@gnprice
Copy link
Member

gnprice commented Sep 30, 2024

Our colors in dark theme are based on those in web. The dark theme in web is getting adjusted to have slightly higher contrast, and we should follow. Details:

For mobile, the specific design from @terpimost can be found here:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4514-33396&t=bMNXsr5LwkrHz4dp-1

@terpimost would you suggest using the exact same values for these in mobile as in web? Or would you prefer to update things in the mobile Figma doc?

Related (but independent) PR

@gnprice gnprice added the a-design Visual and UX design label Sep 30, 2024
@gnprice gnprice added this to the Beta 4: Fall 2024 milestone Sep 30, 2024
@IfeanyiSam
Copy link

Is this issue open to work on? I want to work on this issue if it is open

@donnywellson
Copy link

@zulipbot claim

@donnywellson
Copy link

I would like to be assigned this issue. I have already started by grouping the theme files and makeing the ZulipTheme easier to read and understand

@gnprice
Copy link
Member Author

gnprice commented Oct 7, 2024

I've just updated the issue description with the design freshly provided by @terpimost, so it's possible now to work on this issue.

@donnywellson assigning to you; please go ahead. I'm not sure we'll want to merge rearrangements to the theme code; but as long as you keep them in separate commits, following our style for clean and coherent commits, that won't get in the way of reviewing your main changes.

@IfeanyiSam please take a look at our guide for claiming an issue:
https://zulip.readthedocs.io/en/latest/contributing/contributing.html#in-other-zulip-repositories

@PIG208 PIG208 linked a pull request Oct 8, 2024 that will close this issue
@chrisbobbe chrisbobbe linked a pull request Oct 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-design Visual and UX design
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants