Opening notification sometimes doesn't navigate, on Android

[gnprice]

When I open the app from a notification, sometimes it doesn't navigate to the specific conversation (as it's supposed to do), but instead lands at the home page just as if I'd opened the app directly from the launcher.

I've been seeing this occasionally for a while. Most recently I saw it this morning, running v0.0.31.

Repro attempts

I tried just now to reproduce the issue, and couldn't — it worked correctly each time. Some elements that were present when I did see it today, which might be part of the conditions to make it reproduce:

• I hadn't used the app recently.
• Specifically I was opening the app for the first time of the day, shortly after waking up the device for the first time in the morning.
• The notification was for several messages in one topic, in a channel where I have notifications enabled for all messages.

OTOH the issue didn't reproduce when I tried any of the following conditions:

• I went to the recent-apps screen and swiped the Zulip app away. This is our usual way of getting an "app isn't running" condition for manual testing.

  Then I sent myself a DM from a test account (in the web app), and tried opening the resulting notification.

• I opened the app, then went to the device's home screen. This is our usual way of getting an "app is running in the background" condition for manual testing.

  Then, similarly, I sent myself a DM from a test account (in the web app) and tried opening the resulting notification.

• I also repeated each of the two different setups above, but then sent a channel message mentioning myself (again from a test account) instead of a DM.

[gnprice]

@rajveermalviya would you take a look at this and do some further experiments to see if you can find a reproducer? You've been working in this area.

(It's also possible the bug was introduced somehow by the refactors in #1379. I'm not sure when I first saw the issue, oops — should have recorded it sooner — but it's possible it was after I started running versions of #1379.)