Skip to content

Bounce dock only once on receiving a private message #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kanishk98
Copy link
Collaborator


What's this PR do?

  1. Changes dock badge on macOS from a dot to the unread PM count of the server that last received a PM.
  2. Makes dock bounce only once (as opposed to every time the favicon of the web app is updated)

Any background context you want to provide?

Check out the discussion here.
Server repo PR here.

Screenshots?

Zulip dock

You have tested this PR on:

  • Windows
  • Linux/Ubuntu
  • macOS

@kanishk98
Copy link
Collaborator Author

@akashnimare I'll update this PR based on Tim's response in the server-side repo issues. Shouldn't take more than 10-15 minutes once we confirm that this is required. Hope that's not a problem.

@kanishk98
Copy link
Collaborator Author

After our discussion in #12222, I think we're confident of going ahead with this feature. I've updated the PR. It'll be great if someone can test it out on a Mac on their end and let me know if there are any problems.

@akashnimare
Copy link
Member

@kanishk98 can you fix the merge conflicts? Also, we agreed to merge #12222, right?

@kanishk98
Copy link
Collaborator Author

can you fix the merge conflicts?

Fixed those. :)

Also, we agreed to merge #12222, right?

Yeah, we'd agreed that the server-side notifications page wasn't enough to handle the specific Mac dock bounce issue. I think Tim and Rishi just wanted to wait till we integrated notifications settings into the desktop app. We've done that now, so should be good to merge both these PRs.

@zulipbot
Copy link
Member

Heads up @kanishk98, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants