Add toggle setting for Mac tray icon unread count display #1429
+67
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timabbott
reviewed
Jun 18, 2025
|
Thanks for the PR @Weiged! Can you clean up the commit history in addition to dropping the (I assume AI-generated) translations? Check out our GitHub guide and commit guidelines for more details. |
Weiged
force-pushed
the
main
branch
2 times, most recently
from
cc7608e to
fa2fc00
Compare
Add a new configuration option 'trayBadgeCount' that allows users to display unread message count on the tray icon for macOS. When enabled, the tray icon shows the unread count as a title badge instead of modifying the icon image itself. This change: - Adds trayBadgeCount configuration option to config schema - Adds toggle-tray-badge-count IPC message for preference updates - Implements displayTrayIcon() function to handle platform-specific tray icon display logic - Updates preference UI to show the option only on macOS - Refactors tray logic to use consistent display methods across platforms The feature is macOS-specific because other platforms already use icon overlays to show unread counts, while macOS can use the cleaner title badge approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Mac tray icon functionality by adding user control over unread message count display and improving the visual representation.
Changes:
Fixes:
Improves Mac user experience with system tray functionality. The previous implementation had issues with icon color not automatically switching between black and white based on system theme, and users had no control over whether to show unread counts.
Screenshots and screen captures:
[You should add screenshots showing the tray icon before/after changes and the new toggle setting]
Platforms this PR was tested on:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: