Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy: Clean out or report issues in mypy/typeshed for type: ignores #142

Closed
timabbott opened this issue Oct 27, 2017 · 4 comments
Closed

Comments

@timabbott
Copy link
Member

Now that we've finished #127, it's worth doing a bit of work on the type: ignores in our mypy annotations, trying to fix upstream in typeshed anything where that's possible.

I don't want this issue to remain open forever, so we should happily close this as soon as we've done a sweep through our type: ignore entries.

@neiljp I feel like you'd probably be pretty effective at doing this.

@neiljp
Copy link
Contributor

neiljp commented Nov 15, 2017

@zulipbot claim

@neiljp
Copy link
Contributor

neiljp commented Nov 16, 2017

#157 Should cover most of this, I think?

I think I had a copy/paste issue, as the work on generate_manifest.py I intended to link to
python/mypy#1747, which was my reported issue; the corresponding PR I just worked on is python/mypy#1748.

@timabbott
Copy link
Member Author

Yeah, this seems good enough for this issue (though of course you're welcome to contribute fixes upstream to clean this out further!). Thanks @neiljp!

@neiljp
Copy link
Contributor

neiljp commented Dec 21, 2017

For the record, the correct links I reported and which are now fixed were in python/typeshed, not python/mypy. I'm just putting together a PR which removes these ignores and upgrades to mypy 0.560.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants