Skip to content

Commit 1df19c0

Browse files
akashaviatortimabbott
authored andcommitted
api: update_user_group_members should have a user_group_id parameter.
This avoids weirdly passing an extra field in the request, and also makes the bindings better align with the API.
1 parent 9a4abb9 commit 1df19c0

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

zulip/zulip/__init__.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1454,18 +1454,18 @@ def remove_user_group(self, group_id: int) -> Dict[str, Any]:
14541454
method='DELETE',
14551455
)
14561456

1457-
def update_user_group_members(self, group_data: Dict[str, Any]) -> Dict[str, Any]:
1457+
def update_user_group_members(self, user_group_id: int, group_data: Dict[str, Any]) -> Dict[str, Any]:
14581458
'''
14591459
Example usage:
14601460
1461-
>>> client.update_user_group_members({
1462-
'delete': [4, 8, 15],
1463-
'add': [16, 23, 42],
1461+
>>> client.update_user_group_members(1, {
1462+
'delete': [8, 10],
1463+
'add': [11],
14641464
})
14651465
{'msg': '', 'result': 'success'}
14661466
'''
14671467
return self.call_endpoint(
1468-
url='user_groups/{}/members'.format(group_data['group_id']),
1468+
url='user_groups/{}/members'.format(user_group_id),
14691469
method='POST',
14701470
request=group_data,
14711471
)

0 commit comments

Comments
 (0)