Skip to content

Commit 0d444b3

Browse files
author
ap@apple.com
committed
Stop silencing leaks in TextCodecICU::registerCodecs, as the problem was fixed a while ago.
https://bugs.webkit.org/show_bug.cgi?id=118505 Reviewed by Joseph Pecoraro. * Scripts/valgrind/suppressions.txt: * Scripts/webkitpy/port/leakdetector.py: (LeakDetector._callstacks_to_exclude_from_leaks): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@225240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent a41e4c3 commit 0d444b3

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

Tools/ChangeLog

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
2017-11-28 Alexey Proskuryakov <ap@apple.com>
2+
3+
Stop silencing leaks in TextCodecICU::registerCodecs, as the problem was fixed a while ago.
4+
https://bugs.webkit.org/show_bug.cgi?id=118505
5+
6+
Reviewed by Joseph Pecoraro.
7+
8+
* Scripts/valgrind/suppressions.txt:
9+
* Scripts/webkitpy/port/leakdetector.py:
10+
(LeakDetector._callstacks_to_exclude_from_leaks):
11+
112
2017-11-28 Ms2ger <Ms2ger@igalia.com>
213

314
Stop modifying self.expectations in TestExpectationLine.expected_behavior.

Tools/Scripts/valgrind/suppressions.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -594,8 +594,6 @@
594594
}
595595

596596
{
597-
# TextCodecICU::registerCodecs is leaking https://bugs.webkit.org/show_bug.cgi?id=118505
598-
WebCore::TextCodec::registerCodecs()
599597
Memcheck:Leak
600598
fun:malloc
601599
fun:_ZN3WTF10fastMallocEm

Tools/Scripts/webkitpy/port/leakdetector.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,9 @@ def _types_to_exlude_from_leaks(self):
5454

5555
def _callstacks_to_exclude_from_leaks(self):
5656
callstacks = [
57-
'TextCodecICU::registerCodecs', # https://bugs.webkit.org/show_bug.cgi?id=118505
57+
# List substrings here, e.g.
58+
# 'TextCodecICU::registerCodecs', # https://bugs.webkit.org/show_bug.cgi?id=118505
5859
]
59-
if self._port.operating_system == 'mac' and self._port.is_mavericks():
60-
callstacks += [
61-
'AVAssetResourceLoader _poseAuthenticationChallengeWithKey:data:requestDictionary:fallbackHandler:', # <rdar://problem/19699887> leak in AVFoundation
62-
]
6360
return callstacks
6461

6562
def _leaks_args(self, pid):

0 commit comments

Comments
 (0)