Exporting functions to allow users to have more control on where they… #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set the middleware and run engine
zsais
previously requested changes
Aug 13, 2018
Owner
zsais
left a comment
zsais
left a comment
There was a problem hiding this comment.
Thanks for the PR! Have two small changes then will merge
|
|
||
| func (p *Prometheus) setMetricsPath(e *gin.Engine) { | ||
| // SetMetricsPath set metrics paths | ||
| func (p *Prometheus) SetMetricsPath(e *gin.Engine) { |
Owner
There was a problem hiding this comment.
Can you have this function call into setMetricsPath() so we can maintain backwards-compatibility?
|
|
||
| func (p *Prometheus) setMetricsPathWithAuth(e *gin.Engine, accounts gin.Accounts) { | ||
| // SetMetricsPathWithAuth set metrics paths with authentication | ||
| func (p *Prometheus) SetMetricsPathWithAuth(e *gin.Engine, accounts gin.Accounts) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… set the middleware and run the engine