Adapt code and dependencies to Spark 3.0.1 #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asqasq
commented
Dec 14, 2020
|
|
||
|
|
||
|
|
||
| override def getReaderForRange[K, C]( |
There was a problem hiding this comment.
Unclear how to specify a range for CrailShuffleReader.
asqasq
commented
Dec 14, 2020
| @@ -82,7 +82,7 @@ class CrailShuffleWriter[K, V]( | |||
| initRatio = runTime/initTime | |||
| overhead = 100/initRatio | |||
| logInfo("shuffler writer: initTime " + initTime + ", runTime " + runTime + ", initRatio " + initRatio + ", overhead " + overhead) | |||
| return Some(MapStatus(blockManager.shuffleServerId, sizes)) | |||
| return Some(MapStatus(blockManager.shuffleServerId, sizes, context.taskAttemptId())) | |||
There was a problem hiding this comment.
Unclear what a good value would be. It also works with a constant value.
asqasq
commented
Dec 14, 2020
PepperJo
reviewed
Dec 14, 2020
| @@ -42,6 +42,12 @@ | |||
| <spark.version>2.2.0</spark.version> | |||
| </properties> | |||
| </profile> | |||
| <profile> | |||
| <id>spark-3.0.1</id> | |||
There was a problem hiding this comment.
Do the 2.X profile still work or should we remove them?
| <scope>compile</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.crail</groupId> | ||
| <artifactId>crail-client</artifactId> | ||
| <version>1.2-incubating-SNAPSHOT</version> | ||
| <version>1.3-incubating-SNAPSHOT</version> |
There was a problem hiding this comment.
Should we depend on a non-snapshot? Or are there any changes that require latest and greatest (since we do not push the SNAPSHOT to maven central this would require crail source to compile)
|
|
||
|
|
||
|
|
||
| override def getReaderForRange[K, C]( |
|
Feel free to add yourself as an authors in https://github.com/zrlio/crail-spark-io/blob/master/AUTHORS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the plugin tp Spark 3.0. The version for Spark 2.2.0 is under a new branch spark_2_2_0 so that we can
keep the newest version for the newrest Spark version in master.
I have tested the plugin with Spark 3.0.1, Hadoop 2.7, Apache Crail 1.3 and Crail Spark Terasort
with 1GB, 4GB, 16HB and 64GB and validated the correct sorting with and without this
plugin. I did not run into problems or incorrect sortings.
Please have a look at the code.