-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating testing and (minor) MSVC improvement #78
base: master
Are you sure you want to change the base?
Conversation
* Added test files from Decompyle (https://sourceforge.net/projects/decompyle/) - thanks * Added baseline output results * Made pycdc_test.sh handle baseline comparisons * Added test outputs for Python 2.7 NOTE: Need to check previously non-decompyle tests have been covered.
* New baseline directories * New output directories
Regarding test cases from distributions 1.5.2 - 3.4.2: Some preliminary sorting: These tests produced output, [not validated] These tests crashed [validated as incorrect]: These tests produced bad output [validated as incorrect]: |
Thanks for wider test suite. I welcome and wish to integrate this larger suite however should it be a current CL blocker or new commit? |
those files were dumped from the full regression test foreach python distribution. |
What I mean by blocker or new commit is should your suggestion block committing/merge the change I currently have in the pull request (to make it more ideal with CPythonPyc_test regression tests), or should that be done as a later pull request/commit |
I like your suggestions with the test suite. the additional test cases from cpythonpyc-test do not block this commit. The additional test cases require some restructuring. |
* Removing random 'continue's * Allowing conditions in comprehensions to work
I just came across this. It is a pity this hasn't been acted upon. If someone wants to rework them in the context of uncompyle6's test framework, I'd support that. I see that a number of these come from decompyle's test suite, for example However the better way used in testing now would be to adapt this program to add asserts, so that when this program runs, it checks itself. For example, instead of: no_apply(*args, **args) we would have: assert no_apply(*args, **args) == ... |
I have a bunch of fixes and improvements coming for future pushes, doing an overhaul of the way tests are run so then it can be verified what changed.
TODO: (Minor) - Let me know if any required for pull-request