-
Notifications
You must be signed in to change notification settings - Fork 760
MAKE_FUNCTION & SET_FUNCTION_ATTRIBUTE_A for 3.13 #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Compiled with the 3.4.10-alpine container
Compiled with 3.0.1 locally built container
…a more appropriate area of ASTree
I started looking at CALL_KW and found a bug in my LOAD_ATTR implementation, I put too much inside the if(operand). |
Thanks a lot for your contribution @CarrBen . Unfortunately there seems to be a bug with |
…. Apply 3.13 NULL ordering change to LOAD_GLOBAL
Thanks for taking a look @whoami730, I had spotted an issue with LOAD_ATTR last night, and I'd completely missed updating LOAD_GLOBAL to work with 3.13. I've pushed a further commit with updates for both Opcodes and it passes your test case on my end. |
DRAFT again...
I'm setting this one up as another Draft, as this builds upon the changes in #539 & #538
I've mainly done this because these things naturally build on top of each other as the Opcode evolve when moving forward through the Python versions. For example, the handling of Function arguments within SET_FUNCTION_ATTRIBUTE_A is the same as MAKE_FUNCTION in Python 3.6-3.12.
Summary
Tests
Related Issues
#573
#569
#568
#542
#498