Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile is added to tree even when quick pick is dismissed #2921

Open
traeok opened this issue May 16, 2024 · 1 comment
Open

Profile is added to tree even when quick pick is dismissed #2921

traeok opened this issue May 16, 2024 · 1 comment
Labels
bug Something isn't working priority-low Legit issue but cosmetic or nice-to-have

Comments

@traeok
Copy link
Member

traeok commented May 16, 2024

Describe the bug

When selecting a profile to add to a tree view, users are shown a follow-up prompt that asks if it should be added to all trees or just the selected one. However, if the quick pick is dismissed, it still adds the profile to the tree.

To Reproduce

  1. In one of the tree views, click the "+" button to add a profile
  2. Select a profile from the list
  3. When the follow-up prompt appears asking if it should be added to all trees, dismiss the prompt
  4. Notice that the profile was added anyway

Expected behavior

No profiles should be added if the quick pick is dismissed.

Screenshots

ZE-QuickPick-InvalidSelection

Desktop (please complete the following information):

  • OS: Windows 10
  • Zowe Explorer Version: 2.15.4

Additional context

This might have been intended behavior when the feature was implemented, but it doesn't seem like an appropriate UX here. If we intend to fall back to this behavior when a user dismisses the quick pick, we should make it more obvious so that users are not confused when a profile is added after dismissing the prompt.

@traeok traeok added the bug Something isn't working label May 16, 2024
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@traeok traeok added the priority-low Legit issue but cosmetic or nice-to-have label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-low Legit issue but cosmetic or nice-to-have
Projects
Status: Low Priority
Development

No branches or pull requests

1 participant