Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecating cpage in favor of encoding #1430

Open
zFernand0 opened this issue May 26, 2022 · 1 comment
Open

Consider deprecating cpage in favor of encoding #1430

zFernand0 opened this issue May 26, 2022 · 1 comment
Labels
priority-medium Not functioning - next quarter if capacity permits question Further information is requested

Comments

@zFernand0
Copy link
Member

Based on this discussion: zowe/zowe-explorer-vscode#1815 (comment)

Should we research if it's worth deprecating codePage in favor of encoding

public static readonly PARM_CPAGE: string = "cpage";

@FALLAI-Denis
Copy link

FALLAI-Denis commented May 27, 2022

Hi,

I'm not sure if it's appropriate to change the name of the codePage property for the tso profile.

The encoding declarations for the zosmf and tso profiles are not identical:

  • the zosmf profile uses only one property: encoding
  • the tso profile uses two properties: codePage and characterSet

Having different property names between the zosmf and tso profiles helps to keep in mind thecharacterSetproperty declaration for the tso profile.

Put another way :

  • codePage requires the declaration of a characterSet
  • encoding stands on its own

@zFernand0 zFernand0 added the priority-medium Not functioning - next quarter if capacity permits label Oct 11, 2022
@adam-wolfe adam-wolfe mentioned this issue Jan 4, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-medium Not functioning - next quarter if capacity permits question Further information is requested
Projects
Status: Medium Priority
Development

No branches or pull requests

2 participants