Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI system tests may fail if output exceeds 1 MB #1224

Open
t1m0thyj opened this issue Nov 30, 2021 · 0 comments
Open

CLI system tests may fail if output exceeds 1 MB #1224

t1m0thyj opened this issue Nov 30, 2021 · 0 comments
Labels
priority-low Legit issue but cosmetic or nice-to-have testing

Comments

@t1m0thyj
Copy link
Member

The runCliScript method in the TestUtils module calls child_process.spawnSync which has a default maxBuffer value of 1 MB (see Node.js doc).

Some CLI system tests, particularly ones for the zowe logs list logs command added in #1146, may write >1MB to stdout. When this happens, response.status is null and response.signal is SIGTERM, causing system tests that expect response.status == 0 to fail.

To resolve this, we could increase maxBuffer for all system tests, or at least for ones where we know a larger buffer size may be needed. Alternatively, we could allow for response.status == null in system tests, but that seems undesirable.

@t1m0thyj t1m0thyj added the priority-low Legit issue but cosmetic or nice-to-have label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-low Legit issue but cosmetic or nice-to-have testing
Projects
Status: Low Priority
Development

No branches or pull requests

1 participant