Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude node_modules from test-tsconfig.json #86

Open
zFernand0 opened this issue Jul 30, 2021 · 0 comments
Open

Exclude node_modules from test-tsconfig.json #86

zFernand0 opened this issue Jul 30, 2021 · 0 comments
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers priority-low

Comments

@zFernand0
Copy link
Member

zFernand0 commented Jul 30, 2021

This same issue may apply to other plugins as well.
Solution:

  • Remove fs-extra from the __tests__/__src__/environment/TestEnvironment.ts

Downgraded @types/fs-extra for various reasons:

  • the test-tsconfig.json cannot properly exclude the @types/fs-extra package since the TestEnvironment.ts uses if for mkdirpSync
  • tsconfig.json has to include it's node_modules/typings. See https://stackoverflow.com/a/67512016/16555983
  • @types/fs-extra@^9.0.5 has issues that we may be able to avoid with
    tsconfig.json#compilerOptions.skipLibCheck: true

Note: We may have to upgrade to newer versions of this package for security reasons.

Originally posted by @zFernand0 in #85 (comment)

@zFernand0 zFernand0 added enhancement New feature or request dependencies Pull requests that update a dependency file priority-low good first issue Good for newcomers labels Mar 7, 2023
@t1m0thyj t1m0thyj moved this to Low Priority in Zowe CLI Squad Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers priority-low
Projects
Status: Low Priority
Development

No branches or pull requests

1 participant