fix(components): 🐛 the ref method of the vc-zoom-control component …

…exposed errors
zouyaoji · May 13, 2024 · 7a861ab · 7a861ab
1 parent 1d7137d
commit 7a861ab
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/packages/components/controls/zoom-control/index.ts b/packages/components/controls/zoom-control/index.ts
@@ -240,9 +240,9 @@ export default defineComponent({
     }
 
     Object.assign(instance.proxy, {
-      zoomIn: () => zoomControlState.zoomIn,
-      zoomOut: () => zoomControlState.zoomOut,
-      zoomReset: () => zoomControlState.zoomReset
+      zoomIn: (e?: MouseEvent) => zoomControlState.zoomIn(e),
+      zoomOut: (e?: MouseEvent) => zoomControlState.zoomOut(e),
+      zoomReset: (e?: MouseEvent) => zoomControlState.zoomReset(e)
     })
 
     return () => {

diff --git a/packages/components/controls/zoom-control/use-zoom-control.ts b/packages/components/controls/zoom-control/use-zoom-control.ts
@@ -10,15 +10,15 @@ export default function (props, { emit }, vcInstance: VcComponentInternalInstanc
   const zoomOutTooltipRef = ref<VcTooltipRef>(null)
   const resetTooltipRef = ref<VcTooltipRef>(null)
 
-  const zoomIn = e => {
+  const zoomIn = (e?: MouseEvent) => {
     zoom(1 / props.zoomAmount, e)
   }
 
-  const zoomOut = e => {
+  const zoomOut = (e?: MouseEvent) => {
     zoom(props.zoomAmount, e)
   }
 
-  const zoom = (relativeAmount, e) => {
+  const zoom = (relativeAmount, e?: MouseEvent) => {
     $(zoomInTooltipRef)?.hide()
     $(zoomOutTooltipRef)?.hide()
 
@@ -129,7 +129,7 @@ export default function (props, { emit }, vcInstance: VcComponentInternalInstanc
     }
   }
 
-  const zoomReset = e => {
+  const zoomReset = (e?: MouseEvent) => {
     $(resetTooltipRef)?.hide()
     const { viewer } = $services
     const scene = viewer.scene
@@ -145,7 +145,7 @@ export default function (props, { emit }, vcInstance: VcComponentInternalInstanc
       viewer.trackedEntity = trackedEntity
     } else {
       const listener = getInstanceListener(vcInstance, 'zoomEvt')
-      const target = e.currentTarget
+      const target = e?.currentTarget
       const level = heightToLevel(viewer.camera.positionCartographic.height).toFixed(0)
       // reset to a default position or view defined in the options
       listener &&