Merge pull request #1511 from Adapptor/icon-empty-strings

Support empty strings as default push notification icons

Author: Dallas62

README.md

@@ -303,9 +303,9 @@ PushNotification.localNotification({
   ticker: "My Notification Ticker", // (optional)
   showWhen: true, // (optional) default: true
   autoCancel: true, // (optional) default: true
-  largeIcon: "ic_launcher", // (optional) default: "ic_launcher"
+  largeIcon: "ic_launcher", // (optional) default: "ic_launcher". Use "" for no large icon.
   largeIconUrl: "https://www.example.tld/picture.jpg", // (optional) default: undefined
-  smallIcon: "ic_notification", // (optional) default: "ic_notification" with fallback for "ic_launcher"
+  smallIcon: "ic_notification", // (optional) default: "ic_notification" with fallback for "ic_launcher". Use "" for default small icon.
   bigText: "My big text that will be shown when notification is expanded", // (optional) default: "message" prop
   subText: "This is a subText", // (optional) default: none
   bigPictureUrl: "https://www.example.tld/picture.jpg", // (optional) default: undefined

android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotificationHelper.java

@@ -348,13 +348,13 @@ public void sendToNotificationCentreWithPicture(Bundle bundle, Bitmap largeIconB
             }
 
             // Small icon
-            int smallIconResId;
+            int smallIconResId = 0;
 
             String smallIcon = bundle.getString("smallIcon");
 
             if (smallIcon != null) {
                 smallIconResId = res.getIdentifier(smallIcon, "mipmap", packageName);
-            } else {
+            } else if (!smallIcon.isEmpty()) {
                 smallIconResId = res.getIdentifier("ic_notification", "mipmap", packageName);
             }
 
@@ -370,13 +370,13 @@ public void sendToNotificationCentreWithPicture(Bundle bundle, Bitmap largeIconB
 
             // Large icon
             if(largeIconBitmap == null) {
-                int largeIconResId;
+                int largeIconResId = 0;
 
                 String largeIcon = bundle.getString("largeIcon");
 
                 if (largeIcon != null) {
                     largeIconResId = res.getIdentifier(largeIcon, "mipmap", packageName);
-                } else {
+                } else if (!largeIcon.isEmpty()) {
                     largeIconResId = res.getIdentifier("ic_launcher", "mipmap", packageName);
                 }