Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lazily define if current browser is old IE #5

Merged
merged 1 commit into from
Nov 21, 2020
Merged

fix: Lazily define if current browser is old IE #5

merged 1 commit into from
Nov 21, 2020

Conversation

Djaler
Copy link
Contributor

@Djaler Djaler commented Jun 4, 2020

This will improve treeshakeability

@RaffaeleCanale
Copy link

@znck Would it be possible to get an eye on this?

I've been following this thread (vuejs/rollup-plugin-vue#344) as I'm still experiencing the same issue. After further investigations, I came to the same conclusion that this isOldIE is tripping webpack in believing that the module has side effects and is thus not tree shakeable.

Thanks for your input!

@mgdodge
Copy link

mgdodge commented Sep 21, 2020

This looks like an elegant solution - 👍!

@znck znck merged commit 3239bf5 into znck:master Nov 21, 2020
@Djaler Djaler deleted the lazy-is-old-ie branch November 21, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants