Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "absolute calculation" to RGB effect and speed behavior bindings #673

Open
petejohanson opened this issue Feb 9, 2021 · 0 comments
Open
Labels
behaviors core Core functionality/behavior of ZMK good first issue Good for newcomers

Comments

@petejohanson
Copy link
Contributor

As part of the behavior locality work, we added ability for a behavior binding from "state relative" to "state absolute", and updated many behaviors to add the necessary callbacks.

One behavior not updated full was the RGB Underglow one, in particular:

  • Effect forward/backwards
  • Effect speed selection

Are not currently made absolute based on the current state of the central.

This needs adding to the on_keymap_binding_convert_central_state_dependent_params function in app/src/behaviors/behavior_rgb_underglow.c file.

@petejohanson petejohanson added good first issue Good for newcomers core Core functionality/behavior of ZMK behaviors labels Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behaviors core Core functionality/behavior of ZMK good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant