Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct wire KSCAN driver needs to be migrated to PORT events #272

Closed
petejohanson opened this issue Oct 12, 2020 · 0 comments · Fixed by #359
Closed

Direct wire KSCAN driver needs to be migrated to PORT events #272

petejohanson opened this issue Oct 12, 2020 · 0 comments · Fixed by #359
Labels
core Core functionality/behavior of ZMK enhancement New feature or request good first issue Good for newcomers

Comments

@petejohanson
Copy link
Contributor

petejohanson commented Oct 12, 2020 •
edited
Loading

As part of the deep sleep work in #211, we moved the matrix KSCAN driver to using the nrf "PORT" events, which enables key presses to wake from sleep, and reduces power usage, and allows for more "input pins", since "IN" events have a limit of 8 on that platform.

We didn't do the same work for the direct driver, so those boards won't properly wake from sleep, nor work for large number of input GPIO pins.

It shouldn't be hard to take inspiration from the changes for the matrix driver for this.
@petejohanson petejohanson added core Core functionality/behavior of ZMK enhancement New feature or request good first issue Good for newcomers Hacktoberfest labels Oct 12, 2020
petejohanson added a commit to petejohanson/zmk that referenced this issue Nov 10, 2020
@petejohanson
refactor(kscan): Use PORT events for direct driver
67f3a42 
* Switch interrupt configuration so nRF52 uses
  PORT events for lower power use, and wake
  from deep sleep.
* Closes zmkfirmware#272
@petejohanson petejohanson mentioned this issue Nov 10, 2020
Merged
petejohanson added a commit to petejohanson/zmk that referenced this issue Dec 2, 2020
@petejohanson
refactor(kscan): Use PORT events for direct driver
f1f6687 
* Switch interrupt configuration so nRF52 uses
  PORT events for lower power use, and wake
  from deep sleep.
* Closes zmkfirmware#272
petejohanson added a commit that referenced this issue Dec 2, 2020
@petejohanson
refactor(kscan): Use PORT events for direct driver
e0fede4 
* Switch interrupt configuration so nRF52 uses
  PORT events for lower power use, and wake
  from deep sleep.
* Closes #272
MangoIV pushed a commit to MangoIV/zmk that referenced this issue Dec 18, 2020
@petejohanson
refactor(kscan): Use PORT events for direct driver
64ad36c 
* Switch interrupt configuration so nRF52 uses
  PORT events for lower power use, and wake
  from deep sleep.
* Closes zmkfirmware#272
tyalie pushed a commit to tyalie/zmk that referenced this issue Nov 15, 2022
@petejohanson
refactor(kscan): Use PORT events for direct driver
f393ebc 
* Switch interrupt configuration so nRF52 uses
  PORT events for lower power use, and wake
  from deep sleep.
* Closes zmkfirmware#272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Core functionality/behavior of ZMK enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert direct KSCAN driver to PORT events for power management improvements. petejohanson/zmk
2 participants
@petejohanson @innovaker