Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure pytest to ignore known DeprecationWarnings #233

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

kurtmckee
Copy link
Contributor

Older starlette and pydantic syntax is currently supported, so these warnings are known and expected.

There are still two ResourceWarnings from anyio left to address. These are thrown due to unclosed MemoryObjectReceiveStream objects.

Older starlette and pydantic syntax is currently supported,
so these warnings are known and expected.
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5f93626) to head (1bd6cde).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #233   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           58        58           
  Lines         4732      4732           
  Branches       324       324           
=========================================
  Hits          4732      4732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmievsa
Copy link
Owner

zmievsa commented Dec 12, 2024

What would we need to resolve the resource warnings from anyio?

@kurtmckee
Copy link
Contributor Author

When I set PYTHONTRACEMALLOC, I found that the resources were opened -- but unclosed -- within starlette itself.

I found several open issues in the starlette repo that suggested this was indeed caused by starlette (not by cadwyn's own usage) so I think we're in the clear to simply ignore those ResourceWarnings.

I'll try to find a definitive starlette issue to link to and update this PR to ignore those warnings, together with a comment pointing to the definitive issue...and then lock in the pytest configuration to error on warnings moving forward.

@zmievsa
Copy link
Owner

zmievsa commented Dec 12, 2024

Understood. Thanks!

@zmievsa zmievsa merged commit 2f5a2b6 into zmievsa:main Dec 12, 2024
13 checks passed
@kurtmckee kurtmckee deleted the filter-known-deprecationwarnings branch December 12, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants