Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core.min.js error in Safari 8.0.7 #92

Closed
blopker opened this issue Jul 29, 2015 · 5 comments
Closed

core.min.js error in Safari 8.0.7 #92

blopker opened this issue Jul 29, 2015 · 5 comments

Comments

@blopker
Copy link

blopker commented Jul 29, 2015

It looks like the minifier used is violating the 'use strict'; directive. File used: https://raw.githubusercontent.com/zloirock/core-js/master/client/core.min.js

<!DOCTYPE html>
<html>
<head>
    <title></title>
</head>
<body>
    <script src="./core.min.js"></script>
</body>
</html>

Results in : SyntaxError: Cannot declare a parameter named 'k' as it shadows the name of a strict mode function. core.min.js:8

Unminified version works fine.

Cheers! 🍻
@zloirock
Copy link
Owner

It's old safari bug - wrong strict mode rule. Looks like problem in minification, I thought it was fixed in uglify a long time ago. After rebuild w/o any serious changes core.min.js works in Safari. I'll publish patch release little later.

\cc @mishoo

@blopker
Copy link
Author

blopker commented Jul 30, 2015

Great, I'll give it a go when it's released!

Ah, Safari; The new IE.

@zloirock
Copy link
Owner

I disable compression function names, it should prevent this problem. Available 1.0.1.

@blopker
Copy link
Author

blopker commented Jul 31, 2015

I can confirm this is fixed. Thank you!

@zloirock
Copy link
Owner

Thanks for report :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blopker @zloirock