some %TypedArray% methods fixes

Author: zloirock

CHANGELOG.md

@@ -1,5 +1,7 @@
 ## Changelog
 ##### Unreleased
+- Changed the order of operations in `%TypedArray%.prototype.with` following [proposal-change-array-by-copy/86](https://github.com/tc39/proposal-change-array-by-copy/issues/86)
+- Fixed possible multiple call of `ToBigInt` / `ToNumber` conversion of the argument passed to `%TypedArray%.prototype.fill` polyfill
 - Fixed the kind of error (`TypeError` instead of `Error`) on incorrect `exec` result in `RegExp.prototype.test` polyfill
 - Fixed dependencies of `{ actual, full, features }/typed-array/at` entries
 - Added Electron 20.0 compat data mapping

packages/core-js/internals/to-big-int.js

@@ -0,0 +1,12 @@
+var toPrimitive = require('../internals/to-primitive');
+
+var $TypeError = TypeError;
+
+// `ToBigInt` abstract operation
+// https://tc39.es/ecma262/#sec-tobigint
+module.exports = function (argument) {
+  var prim = toPrimitive(argument, 'number');
+  if (typeof prim == 'number') throw $TypeError("Can't convert number to bigint");
+  // eslint-disable-next-line es-x/no-bigint -- safe
+  return BigInt(prim);
+};

packages/core-js/modules/es.typed-array.fill.js

@@ -1,20 +1,20 @@
 'use strict';
 var ArrayBufferViewCore = require('../internals/array-buffer-view-core');
-var call = require('../internals/function-call');
 var $fill = require('../internals/array-fill');
+var toBigInt = require('../internals/to-big-int');
+var classof = require('../internals/classof');
+var call = require('../internals/function-call');
+var uncurryThis = require('../internals/function-uncurry-this');
 
 var aTypedArray = ArrayBufferViewCore.aTypedArray;
 var exportTypedArrayMethod = ArrayBufferViewCore.exportTypedArrayMethod;
+var slice = uncurryThis(''.slice);
 
 // `%TypedArray%.prototype.fill` method
 // https://tc39.es/ecma262/#sec-%typedarray%.prototype.fill
 exportTypedArrayMethod('fill', function fill(value /* , start, end */) {
   var length = arguments.length;
-  return call(
-    $fill,
-    aTypedArray(this),
-    value,
-    length > 1 ? arguments[1] : undefined,
-    length > 2 ? arguments[2] : undefined
-  );
+  aTypedArray(this);
+  var actualValue = slice(classof(this), 0, 3) === 'Big' ? toBigInt(value) : +value;
+  return call($fill, this, actualValue, length > 1 ? arguments[1] : undefined, length > 2 ? arguments[2] : undefined);
 });

packages/core-js/modules/esnext.typed-array.with.js

@@ -1,13 +1,21 @@
 'use strict';
 var arrayWith = require('../internals/array-with');
 var ArrayBufferViewCore = require('../internals/array-buffer-view-core');
+var toIntegerOrInfinity = require('../internals/to-integer-or-infinity');
+var toBigInt = require('../internals/to-big-int');
+var classof = require('../internals/classof');
+var uncurryThis = require('../internals/function-uncurry-this');
 
 var aTypedArray = ArrayBufferViewCore.aTypedArray;
 var exportTypedArrayMethod = ArrayBufferViewCore.exportTypedArrayMethod;
 var TYPED_ARRAY_CONSTRUCTOR = ArrayBufferViewCore.TYPED_ARRAY_CONSTRUCTOR;
+var slice = uncurryThis(''.slice);
 
 // `%TypedArray%.prototype.with` method
 // https://tc39.es/proposal-change-array-by-copy/#sec-%typedarray%.prototype.with
 exportTypedArrayMethod('with', { 'with': function (index, value) {
-  return arrayWith(aTypedArray(this), this[TYPED_ARRAY_CONSTRUCTOR], index, value);
+  aTypedArray(this);
+  var relativeIndex = toIntegerOrInfinity(index);
+  var actualValue = slice(classof(this), 0, 3) === 'Big' ? toBigInt(value) : +value;
+  return arrayWith(this, this[TYPED_ARRAY_CONSTRUCTOR], relativeIndex, actualValue);
 } }['with']);

tests/tests/es.typed-array.fill.js

@@ -1,3 +1,4 @@
+import { createConversionChecker } from '../helpers/helpers';
 import { DESCRIPTORS, GLOBAL, TYPED_ARRAYS } from '../helpers/constants';
 
 if (DESCRIPTORS) QUnit.test('%TypedArrayPrototype%.fill', assert => {
@@ -17,5 +18,10 @@ if (DESCRIPTORS) QUnit.test('%TypedArrayPrototype%.fill', assert => {
     assert.arrayEqual(new TypedArray(5).fill(5, 6, 1), [0, 0, 0, 0, 0], 'start > end');
     assert.arrayEqual(new TypedArray(5).fill(5, -3, 4), [0, 0, 5, 5, 0], 'negative start index');
     assert.throws(() => fill.call([0], 1), "isn't generic");
+
+    const checker = createConversionChecker(10);
+    assert.same(new TypedArray(5).fill(checker)[2], 10);
+    assert.same(checker.$valueOf, 1, 'valueOf calls');
+    assert.same(checker.$toString, 0, 'toString calls');
   }
 });

tests/tests/esnext.typed-array.with.js

@@ -1,3 +1,4 @@
+import { createConversionChecker } from '../helpers/helpers';
 import { DESCRIPTORS, GLOBAL, TYPED_ARRAYS } from '../helpers/constants';
 
 if (DESCRIPTORS) QUnit.test('%TypedArrayPrototype%.with', assert => {
@@ -24,5 +25,10 @@ if (DESCRIPTORS) QUnit.test('%TypedArrayPrototype%.with', assert => {
     assert.throws(() => withAt.call(null, 1, 2), TypeError, "isn't generic #1");
     assert.throws(() => withAt.call(undefined, 1, 2), TypeError, "isn't generic #2");
     assert.throws(() => withAt.call([1, 2], 1, 3), TypeError, "isn't generic #3");
+
+    const checker = createConversionChecker(10);
+    assert.same(new TypedArray(5).with(2, checker)[2], 10);
+    assert.same(checker.$valueOf, 1, 'valueOf calls');
+    assert.same(checker.$toString, 0, 'toString calls');
   }
 });