update eslint-plugin-unicorn

Author: zloirock

README.md

@@ -1576,15 +1576,11 @@ Symbol().description;      // => undefined
 You can disable defining setters in `Object.prototype`. [Example](https://tinyurl.com/2blse6aa):
 ```js
 Symbol.useSimple();
-let symbol1 = Symbol('symbol1');
-let object1 = {};
-object1[symbol1] = true;
+let object1 = { [Symbol('symbol1')]: true };
 for (let key in object1) console.log(key); // => 'Symbol(symbol1)_t.qamkg9f3q', w/o native Symbol
 
 Symbol.useSetter();
-let symbol2 = Symbol('symbol2');
-let object2 = {};
-object2[symbol2] = true;
+let object2 = { [Symbol('symbol2')]: true };
 for (let key in object2) console.log(key); // nothing
 ```
 - Currently, `core-js` does not add setters to `Object.prototype` for well-known symbols for correct work something like `Symbol.iterator in foo`. It can cause problems with their enumerability.

docs/web/docs/features/ecmascript/symbol.md

@@ -121,15 +121,11 @@ Symbol().description;      // => undefined
 You can disable defining setters in `Object.prototype`. *Example*:
 ```ts
 Symbol.useSimple();
-let symbol1 = Symbol('symbol1');
-let object1 = {};
-object1[symbol1] = true;
+let object1 = { [Symbol('symbol1')]: true };
 for (let key in object1) console.log(key); // => 'Symbol(symbol1)_t.qamkg9f3q', w/o native Symbol
 
 Symbol.useSetter();
-let symbol2 = Symbol('symbol2');
-let object2 = {};
-object2[symbol2] = true;
+let object2 = { [Symbol('symbol2')]: true };
 for (let key in object2) console.log(key); // nothing
 ```
 - Currently, `core-js` does not add setters to `Object.prototype` for well-known symbols for correct work something like `Symbol.iterator in foo`. It can cause problems with their enumerability.

packages/core-js/internals/check-correctness-of-iteration.js

@@ -14,6 +14,7 @@ try {
       SAFE_CLOSING = true;
     }
   };
+  // eslint-disable-next-line unicorn/no-immediate-mutation -- ES3 syntax limitation
   iteratorWithReturn[ITERATOR] = function () {
     return this;
   };
@@ -28,6 +29,7 @@ module.exports = function (exec, SKIP_CLOSING) {
   var ITERATION_SUPPORT = false;
   try {
     var object = {};
+    // eslint-disable-next-line unicorn/no-immediate-mutation -- ES3 syntax limitation
     object[ITERATOR] = function () {
       return {
         next: function () {

packages/core-js/internals/fix-regexp-well-known-symbol-logic.js

@@ -17,6 +17,7 @@ module.exports = function (KEY, exec, FORCED, SHAM) {
   var DELEGATES_TO_SYMBOL = !fails(function () {
     // String methods call symbol-named RegExp methods
     var O = {};
+    // eslint-disable-next-line unicorn/no-immediate-mutation -- ES3 syntax limitation
     O[SYMBOL] = function () { return 7; };
     return ''[KEY](O) !== 7;
   });
@@ -30,12 +31,13 @@ module.exports = function (KEY, exec, FORCED, SHAM) {
       // We can't use real regex here since it causes deoptimization
       // and serious performance degradation in V8
       // https://github.com/zloirock/core-js/issues/306
-      re = {};
       // RegExp[@@split] doesn't call the regex's exec method, but first creates
       // a new one. We need to return the patched regex when creating the new one.
-      re.constructor = {};
-      re.constructor[SPECIES] = function () { return re; };
-      re.flags = '';
+      var constructor = {};
+      // eslint-disable-next-line unicorn/no-immediate-mutation -- ES3 syntax limitation
+      constructor[SPECIES] = function () { return re; };
+      re = { constructor: constructor, flags: '' };
+      // eslint-disable-next-line unicorn/no-immediate-mutation -- ES3 syntax limitation
       re[SYMBOL] = /./[SYMBOL];
     }
 

packages/core-js/internals/internal-metadata.js

@@ -60,6 +60,7 @@ var enable = function () {
   var getOwnPropertyNames = getOwnPropertyNamesModule.f;
   var splice = uncurryThis([].splice);
   var test = {};
+  // eslint-disable-next-line unicorn/no-immediate-mutation -- ES3 syntax limitation
   test[METADATA] = 1;
 
   // prevent exposing of metadata key

packages/core-js/internals/set-method-accept-set-like.js

@@ -48,9 +48,7 @@ module.exports = function (name, callback) {
         new Set()[name](createSetLikeWithInfinitySize(-Infinity));
         return false;
       } catch (error) {
-        var set = new Set();
-        set.add(1);
-        set.add(2);
+        var set = new Set([1, 2]);
         return callback(set[name](createSetLikeWithInfinitySize(Infinity)));
       }
     }

packages/core-js/internals/to-string-tag-support.js

@@ -3,7 +3,7 @@ var wellKnownSymbol = require('../internals/well-known-symbol');
 
 var TO_STRING_TAG = wellKnownSymbol('toStringTag');
 var test = {};
-
+// eslint-disable-next-line unicorn/no-immediate-mutation -- ES3 syntax limitation
 test[TO_STRING_TAG] = 'z';
 
 module.exports = String(test) === '[object z]';

packages/core-js/modules/es.error.cause.js

@@ -13,13 +13,15 @@ var FORCED = new Error('e', { cause: 7 }).cause !== 7;
 
 var exportGlobalErrorCauseWrapper = function (ERROR_NAME, wrapper) {
   var O = {};
+  // eslint-disable-next-line unicorn/no-immediate-mutation -- ES3 syntax limitation
   O[ERROR_NAME] = wrapErrorConstructorWithCause(ERROR_NAME, wrapper, FORCED);
   $({ global: true, constructor: true, arity: 1, forced: FORCED }, O);
 };
 
 var exportWebAssemblyErrorCauseWrapper = function (ERROR_NAME, wrapper) {
   if (WebAssembly && WebAssembly[ERROR_NAME]) {
     var O = {};
+    // eslint-disable-next-line unicorn/no-immediate-mutation -- ES3 syntax limitation
     O[ERROR_NAME] = wrapErrorConstructorWithCause(WEB_ASSEMBLY + '.' + ERROR_NAME, wrapper, FORCED);
     $({ target: WEB_ASSEMBLY, stat: true, constructor: true, arity: 1, forced: FORCED }, O);
   }

tests/compat/tests.js

@@ -272,9 +272,7 @@ function createSetMethodTest(METHOD_NAME, callback) {
           new Set()[METHOD_NAME](createSetLikeWithInfinitySize(-Infinity));
           return false;
         } catch (error) {
-          var set = new Set();
-          set.add(1);
-          set.add(2);
+          var set = new Set([1, 2]);
           return callback(set[METHOD_NAME](createSetLikeWithInfinitySize(Infinity)));
         }
       }

tests/eslint/eslint.config.js

@@ -604,6 +604,11 @@ const base = {
   'unicorn/no-console-spaces': ERROR,
   // enforce the use of unicode escapes instead of hexadecimal escapes
   'unicorn/no-hex-escape': ERROR,
+  // disallow immediate mutation after variable assignment
+  // that cause problems with objects in ES3 syntax, but since unicorn team
+  // don't wanna add an option to allow it, manually disable this rule in such problem cases
+  // https://github.com/sindresorhus/eslint-plugin-unicorn/issues/2796
+  'unicorn/no-immediate-mutation': ERROR,
   // disallow `instanceof` with built-in objects
   'unicorn/no-instanceof-builtins': [ERROR, { strategy: 'loose' }],
   // disallow invalid options in `fetch` and `Request`
@@ -640,6 +645,8 @@ const base = {
   'unicorn/no-unreadable-iife': ERROR,
   // disallow unused object properties
   'unicorn/no-unused-properties': ERROR,
+  // disallow useless values or fallbacks in `Set`, `Map`, `WeakSet`, or `WeakMap`
+  'unicorn/no-useless-collection-argument': ERROR,
   // disallow unnecessary `Error.captureStackTrace()`
   'unicorn/no-useless-error-capture-stack-trace': ERROR,
   // forbid useless fallback when spreading in object literals
@@ -708,6 +715,8 @@ const base = {
   'unicorn/prefer-object-from-entries': ERROR,
   // prefer omitting the `catch` binding parameter
   'unicorn/prefer-optional-catch-binding': ERROR,
+  // prefer `Response.json()` over `new Response(JSON.stringify())`
+  'unicorn/prefer-response-static-json': ERROR,
   // prefer using `structuredClone` to create a deep clone
   'unicorn/prefer-structured-clone': ERROR,
   // prefer using `Set#size` instead of `Array#length`
@@ -1938,6 +1947,8 @@ const tests = {
   'unicorn/error-message': OFF,
   // prefer `Array#toReversed()` over `Array#reverse()`
   'unicorn/no-array-reverse': OFF,
+  // disallow immediate mutation after variable assignment
+  'unicorn/no-immediate-mutation': OFF,
   // disallow `instanceof` with built-in objects
   'unicorn/no-instanceof-builtins': OFF,
   // prefer `.at()` method for index access and `String#charAt()`