From a76175184e638eddfbbb2d4c738336bb22b0f1cc Mon Sep 17 00:00:00 2001 From: Igor Aleksanov Date: Tue, 19 Dec 2023 10:56:11 +0400 Subject: [PATCH] feat: remove `Provider.getConfirmedTokens` method BREAKING CHANGE: this method will be removed from JSON RPC API. --- src/provider.ts | 11 +++-------- tests/integration/provider.test.ts | 9 +-------- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/src/provider.ts b/src/provider.ts index a015f27c..0ca873c0 100644 --- a/src/provider.ts +++ b/src/provider.ts @@ -400,7 +400,7 @@ export class Provider extends ethers.providers.JsonRpcProvider { if (l2WethToken != ethers.constants.AddressZero) { return l2WethToken; } - } catch (e) {} + } catch (e) { } const l2Erc20Bridge = IL2BridgeFactory.connect(bridgeAddresses.erc20L2, this); return await l2Erc20Bridge.l2TokenAddress(token); } @@ -418,7 +418,7 @@ export class Provider extends ethers.providers.JsonRpcProvider { if (l1WethToken != ethers.constants.AddressZero) { return l1WethToken; } - } catch (e) {} + } catch (e) { } const erc20Bridge = IL2BridgeFactory.connect(bridgeAddresses.erc20L2, this); return await erc20Bridge.l1TokenAddress(token); } @@ -580,11 +580,6 @@ export class Provider extends ethers.providers.JsonRpcProvider { }; } - async getConfirmedTokens(start: number = 0, limit: number = 255): Promise { - const tokens: Token[] = await this.send("zks_getConfirmedTokens", [start, limit]); - return tokens.map((token) => ({ address: token.l2Address, ...token })); - } - async getTokenPrice(token: Address): Promise { return await this.send("zks_getTokenPrice", [token]); } @@ -668,7 +663,7 @@ export class Provider extends ethers.providers.JsonRpcProvider { let l1WethToken = ethers.constants.AddressZero; try { l1WethToken = await l2WethBridge.l1TokenAddress(tx.token); - } catch (e) {} + } catch (e) { } tx.bridgeAddress = l1WethToken != ethers.constants.AddressZero ? bridgeAddresses.wethL2 diff --git a/tests/integration/provider.test.ts b/tests/integration/provider.test.ts index fdf42c90..589ac400 100644 --- a/tests/integration/provider.test.ts +++ b/tests/integration/provider.test.ts @@ -1,7 +1,7 @@ import { expect } from "chai"; import { Provider, types, utils, Wallet } from "../../src"; import { BigNumber, ethers } from "ethers"; -import {TOKENS} from "../const"; +import { TOKENS } from "../const"; describe("Provider", () => { const ADDRESS = "0x36615Cf349d7F6344891B1e7CA7C72883F5dc049"; @@ -141,13 +141,6 @@ describe("Provider", () => { }); }); - describe("#getConfirmedTokens()", () => { - it("should return confirmed tokens", async () => { - const result = await provider.getConfirmedTokens(); - expect(result).to.have.lengthOf(2); - }); - }); - describe("#getDefaultBridgeAddresses()", () => { it("should return default bridges", async () => { const result = await provider.getDefaultBridgeAddresses();