fix(child): exec does not have the information needed to correctly es…

…cape its args
zkat · Jun 20, 2017 · 6714992 · 6714992
1 parent bd4e538
commit 6714992
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/child.js b/child.js
@@ -44,12 +44,12 @@ function exec (cmd, args, opts) {
   opts = opts || {}
   return BB.fromNode(cb => {
     cp.exec(`${escapeArg(cmd, true)} ${
-      args.map(arg => escapeArg(arg)).join(' ')
+      args.join(' ')
     }`, opts, cb)
   })
 }
 
-module.exports._escapeArg = escapeArg
+module.exports.escapeArg = escapeArg
 function escapeArg (str, asPath) {
   return process.platform === 'win32' && asPath
   ? path.normalize(str)

diff --git a/index.js b/index.js
@@ -141,7 +141,7 @@ function getNpmCache (opts) {
   return which(opts.npm).then(npmPath => {
     const args = ['config', 'get', 'cache']
     if (opts.userconfig) {
-      args.push('--userconfig', opts.userconfig)
+      args.push('--userconfig', child.escapeArg(opts.userconfig, true))
     }
     return child.exec(npmPath, args)
   }).then(cache => cache.trim())