bn254 sqrt and decompression (lambdaclass#905)

* save work

* add sqrt for bn254

* compression and decompression for G1 working

* save work

* g2 decompress working with sqrt input 0

* add random sqrt test

* change trait and add documentation

* fix bls compression and decompression

* fix cargo clippy and check

* resolve conversations

* decompression check bytes length

* decompression checks correct bytes length

* fix clippy no default features

* fix ubuntu cargo clippy

* fix ubuntu clippy

* fix errors

* fmt

* fix clippy

* change compress g2 function

* check correct input bytes in decompress_g2_point function for bls12

---------

Co-authored-by: jotabulacios <jbulacios@fi.uba.ar>
Co-authored-by: Nicole <nicole@Nicoles-Air.fibertel.com.ar>
Co-authored-by: Nicole <nicole@Nicoles-MacBook-Air.local>
Co-authored-by: Joaquin Carletti <56092489+ColoCarletti@users.noreply.github.com>
Co-authored-by: diegokingston <dkingston@fi.uba.ar>
Co-authored-by: Diego K <43053772+diegokingston@users.noreply.github.com>

Author: 6 people

math/Cargo.toml

@@ -8,11 +8,15 @@ license.workspace = true
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-serde = { version = "1.0", default-features = false, features = ["derive"], optional = true }
-serde_json = { version = "1.0", default-features = false, features = ["alloc"], optional = true }
+serde = { version = "1.0", default-features = false, features = [
+    "derive",
+], optional = true }
+serde_json = { version = "1.0", default-features = false, features = [
+    "alloc",
+], optional = true }
 proptest = { version = "1.1.0", optional = true }
 winter-math = { package = "winter-math", version = "0.6.4", default-features = false, optional = true }
-miden-core = { package = "miden-core" , version = "0.7", default-features = false, optional = true }
+miden-core = { package = "miden-core", version = "0.7", default-features = false, optional = true }
 
 # rayon
 rayon = { version = "1.7", optional = true }
@@ -28,13 +32,13 @@ cudarc = { version = "0.9.7", optional = true }
 lambdaworks-gpu = { workspace = true, optional = true }
 
 [dev-dependencies]
-rand = { version = "0.8.5", default-features = false }
+rand = { version = "0.8.5", features = ["std"] }
 rand_chacha = "0.3.1"
 criterion = "0.5.1"
 const-random = "0.1.15"
 iai-callgrind.workspace = true
 proptest = "1.1.0"
-pprof = { version = "0.13.0", features = ["criterion","flamegraph"] }
+pprof = { version = "0.13.0", features = ["criterion", "flamegraph"] }
 
 [features]
 default = ["parallel", "std"]
@@ -97,4 +101,3 @@ harness = false
 name = "criterion_metal"
 harness = false
 required-features = ["metal"]
-

math/src/elliptic_curve/short_weierstrass/curves/bls12_381/compression.rs

@@ -57,7 +57,10 @@ impl Compress for BLS12381Curve {
         }
     }
 
-    fn decompress_g1_point(input_bytes: &mut [u8; 48]) -> Result<Self::G1Point, Self::Error> {
+    fn decompress_g1_point(input_bytes: &mut [u8]) -> Result<Self::G1Point, Self::Error> {
+        if !input_bytes.len() == 48 {
+            return Err(ByteConversionError::InvalidValue);
+        }
         let first_byte = input_bytes.first().unwrap();
         // We get the 3 most significant bits
         let prefix_bits = first_byte >> 5;
@@ -150,7 +153,11 @@ impl Compress for BLS12381Curve {
         }
     }
 
-    fn decompress_g2_point(input_bytes: &mut [u8; 96]) -> Result<Self::G2Point, Self::Error> {
+    fn decompress_g2_point(input_bytes: &mut [u8]) -> Result<Self::G2Point, Self::Error> {
+        if !input_bytes.len() == 96 {
+            return Err(ByteConversionError::InvalidValue);
+        }
+
         let first_byte = input_bytes.first().unwrap();
 
         // We get the first 3 bits