Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PHP 5.3 and test against PHP 5.5 #18

Open
hjr3 opened this issue Oct 28, 2014 · 3 comments
Open

Deprecate PHP 5.3 and test against PHP 5.5 #18

hjr3 opened this issue Oct 28, 2014 · 3 comments

Comments

@hjr3
Copy link
Collaborator

hjr3 commented Oct 28, 2014

PHP 5.3 is end of life. I vote we tag php-5.3 which maintains PHP 5.3 support and break BC.

@baldurrensch
Copy link
Collaborator

Agreed.

@DannyvdSluijs
Copy link

I'm always a bit confused on why these remarks are deemed valid. I understand that from aPHP perspective it is EOL. However when looking from an OS perspective Ubuntu 12.04 which has PHP 5.3.10 installed from the Main. Ubuntu 12.04 LTS still is supported from April '17. I going out on limb that the probably are other distributions as well.

I would very like to change my production environments but can't. Is there a great benefit to no longer support 5.3.10 ?

@hjr3
Copy link
Collaborator Author

hjr3 commented Mar 26, 2016

We can still support 5.3.10. I want to tag a branch for 5.3 and master would break 5.3 support. The reason this came up was because issue #14 was asking for JSON_PRETTY_PRINT support, which is available when >= 5.4.0.

I was going to use semver to increase the major version number, so anyone working on with 5.3.x would be unaffected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants