Add ability to pass array parameters to requests

[rilian]

now it is possible to send

  do_request(:array => [1, 2])

and get in controller

  params[:array] == [1, 2]

[travisbot]

This pull request fails (merged a96ef34 into 4c76c40).

[rilian]

timeout on travis :)

[oestrich]

If it's possible, I think using the Rack::Test::Utils#build_nested_query helper for this would be cleaner.

https://github.com/brynary/rack-test/blob/master/lib/rack/test/utils.rb#L7

[rilian]

hi @oestrich , do you have a working example of it with rspec_api_documentation ?

[oestrich]

I don't, but you can see it being called here

https://github.com/brynary/rack-test/blob/master/lib/rack/test.rb#L198

My guess is that you can just call it directly since it's a module function.

[rilian]

so you propose to get rid of do_request at all ?

and send requests through client.get(path, params, headers)

[oestrich]

Could you extend the HTML output feature to send a an array, as well as the OAuth2 feature? What you wrote seems to be mostly for documentation purposes, and we just want to verify that.

I don't think we'd get rid of do_request, but if we can knock most of the complexity out of it and let Rack::Test and the other clients handle it, that'd be great.

[rilian]

yep - we use this gem and specs DSL purely for documenting the API ...