Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve error is throwed from graphql package when toggleConnection != null & Upgrate connectivity_plus #1434

Closed
wants to merge 0 commits into from

Conversation

hantrungkien
Copy link
Contributor

@hantrungkien hantrungkien commented May 27, 2024

  1. Resolve: error is throwed from graphql package (althought it doesn't make any crash) when toggleConnection != null.
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: ValueStream has no value. You should check ValueStream.hasValue before accessing ValueStream.value, or use ValueStream.valueOrNull instead.
      BehaviorSubject.value (package:rxdart/src/subjects/behavior_subject.dart:146:5)
      SocketClient._listenToToggleConnection.<anonymous closure> (package:graphql/src/links/websocket_link/websocket_client.dart:264:40)
      _RootZone.runUnaryGuarded (dart:async/zone.dart:1594:10)
      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
      _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
      _MultiStreamController.addSync (dart:async/stream_impl.dart:1101:36)
      _MultiControllerSink.add (package:rxdart/src/utils/forwarding_stream.dart:130:35)
      _TakeUntilStreamSink.onData (package:rxdart/src/transformers/take_until.dart:13:31)
  1. Upgrate: connectivity_plus: ^6.0.3 for graphql_flutter package.

2 important commits:

@hantrungkien
Copy link
Contributor Author

@vincenzopalazzo please review help me. Thanks a lot!

@vincenzopalazzo
Copy link
Collaborator

Thanks, I just realized that the commit are not following our hacking guide, and this mean that the changelog will generate in the wrong way.

Please read it https://zino-hofmann.github.io/graphql-flutter/docs/dev/MAINTAINERS.html and push the changes when the PR is final and compliant with the document in this way I can merge and release the package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants