Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

milvus operator is difficult to install as a dependent chart due to the inconsistent use of release.Name and release.FullName #135

Open
butler54 opened this issue Jun 20, 2024 · 1 comment
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@butler54
Copy link

I wanted to install milvus for various reasons as a dependent chart e.g.

milvus/
milvus/Chart.yaml
milvus/values.yaml

where: Chart.yaml

apiVersion: v2
name: milvus
description: A Helm chart deploying milvus via the operator

type: application
version: 0.1.0
appVersion: "1.0.0"

dependencies:
- name: milvus-operator
  version: "0.9.16"
  repository: "https://zilliztech.github.io/milvus-operator/"

values.yaml

is empty.

The problem is Release.fullName becomes milvus-milvus-operator and release.Name becomes milvus.

This results in inconsistencies around the Certificate generated. The only way to make this work is to set the following in values.yaml

milvus-operator:
  fullnameOverride: "milvus"
@haorenfsa haorenfsa added the bug Something isn't working label Jun 21, 2024
@haorenfsa haorenfsa self-assigned this Jun 21, 2024
@haorenfsa
Copy link
Collaborator

Hi @butler54, thank you for feedback! We'll fix this later. Or if you'd like to, you may could open a PR to fix this.

@haorenfsa haorenfsa added the good first issue Good for newcomers label Jun 21, 2024
@haorenfsa haorenfsa added this to the v1.2.0 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants