-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: benchmark script #600
Comments
@songsey |
It doesn’t seem to me llm adapter is going to raise an exception if it doesn’t meet the theshold requirement? |
Got it. When running this script, the network should be disconnected, which means that when you need to access openai, an error will be reported, which means that the cache is invalid. |
Can you check the script with LangChainLLM class ? It doesn’t seem to “disconnect” |
Current Behavior
The llm adapter does not fail but it only to generate directly from llm when the similarity threshold is close enough to the maximum distance. It means what you get is either a positive or a negative hit. There is no cache miss. So I'm not sure what it is trying to do with try-except block in the code below ?
https://github.com/zilliztech/GPTCache/blob/main/examples/benchmark/benchmark_sqlite_faiss_onnx.py
Can you update for the benchmark code that you used to generate the figures in the report in the examples folder ?
Expected Behavior
No response
Steps To Reproduce
No response
Environment
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: